[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 01/10] bsd-user: Don't truncate the return value from freebsd_sysc
From: |
Warner Losh |
Subject: |
[PULL 01/10] bsd-user: Don't truncate the return value from freebsd_syscall |
Date: |
Wed, 1 Mar 2023 11:23:44 -0700 |
From: Doug Rabson <dfr@rabson.org>
System call return values on FreeBSD are in a register (which is spelled
abi_long in qemu). This was being assigned into an int variable which
causes problems for 64bit targets.
Resolves: https://github.com/qemu-bsd-user/qemu-bsd-user/issues/40
Signed-off-by: Doug Rabson <dfr@rabson.org>
Reviewed-by: Warner Losh <imp@bsdimp.com>
[ Edited commit message for upstreaming into qemu-project ]
Signed-off-by: Warner Losh <imp@bsdimp.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
bsd-user/freebsd/os-syscall.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bsd-user/freebsd/os-syscall.c b/bsd-user/freebsd/os-syscall.c
index 57996cad8ae..b4a663fc021 100644
--- a/bsd-user/freebsd/os-syscall.c
+++ b/bsd-user/freebsd/os-syscall.c
@@ -512,7 +512,7 @@ abi_long do_freebsd_syscall(void *cpu_env, int num,
abi_long arg1,
abi_long arg8)
{
CPUState *cpu = env_cpu(cpu_env);
- int ret;
+ abi_long ret;
trace_guest_user_syscall(cpu, num, arg1, arg2, arg3, arg4, arg5, arg6,
arg7, arg8);
if (do_strace) {
--
2.39.1
- [PULL 00/10] Bsd user 2023q1 patches, Warner Losh, 2023/03/01
- [PULL 01/10] bsd-user: Don't truncate the return value from freebsd_syscall,
Warner Losh <=
- [PULL 02/10] build: Don't specify -no-pie for --static user-mode programs, Warner Losh, 2023/03/01
- [PULL 03/10] bsd-user: Add sysarch syscall, Warner Losh, 2023/03/01
- [PULL 04/10] bsd-user: various helper routines for sysctl, Warner Losh, 2023/03/01
- [PULL 05/10] bsd-user: Helper routines oidfmt, Warner Losh, 2023/03/01
- [PULL 06/10] bsd-user: sysctl helper funtions: sysctl_name2oid and sysctl_oidfmt, Warner Losh, 2023/03/01
- [PULL 07/10] bsd-user: common routine do_freebsd_sysctl_oid for all sysctl variants, Warner Losh, 2023/03/01
- [PULL 08/10] bsd-user: Start translation of arch-specific sysctls, Warner Losh, 2023/03/01
- [PULL 09/10] bsd-user: do_freebsd_sysctl helper for sysctl(2), Warner Losh, 2023/03/01
- [PULL 10/10] bsd-user: implement sysctlbyname(2), Warner Losh, 2023/03/01
- Re: [PULL 00/10] Bsd user 2023q1 patches, Peter Maydell, 2023/03/02