Re: [PATCH 1/2] hw/vfio/migration: Remove unused 'exec/ram_addr.h' header

[Thomas Huth]

On 27/02/2023 17.04, Peter Maydell wrote:
> On Mon, 27 Feb 2023 at 15:46, Alex Williamson
> <alex.williamson@redhat.com> wrote:
> > On Mon, 27 Feb 2023 11:32:57 +0100
> > Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
> >
> > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> >
> > Empty commit logs are a pet peeve of mine, there must be some sort of
> > motivation for the change, something that changed to make this
> > possible, or perhaps why this was never necessary.  Thanks,
>
> I generally agree, but "this file doesn't actually need to
> include this header" seems straightforward enough that the commit
> subject says everything you'd want to say about it.

But not giving any description at all is really just bad style, we should 
avoid it. And in this case, there is even a good reason that should be 
mentioned here (e.g. "This header was the only reason this file needed to be 
built per target"). So I think it's fair to ask for a proper commit log 
message here.

 Thomas