Re: [PATCH 12/12] hw: Move ich9.h to southbridge/

[Michael S. Tsirkin]

On Mon, Feb 27, 2023 at 01:22:37PM +0100, Philippe Mathieu-Daudé wrote:
> On 13/2/23 18:30, Bernhard Beschow wrote:
> > ICH9 is a south bridge which doesn't necessarily depend on x86, so move
> > it into the southbridge folder, analoguous to PIIX.
> 
> However it is still tied to it due to:
> 
> hw/isa/lpc_ich9.c:315:    cpu_interrupt(first_cpu, CPU_INTERRUPT_SMI);
> hw/isa/lpc_ich9.c:462:                cpu_interrupt(cs, CPU_INTERRUPT_SMI);
> hw/isa/lpc_ich9.c:465:            cpu_interrupt(current_cpu,
> CPU_INTERRUPT_SMI);
> target/i386/cpu.h:1145:#define CPU_INTERRUPT_SMI CPU_INTERRUPT_TGT_EXT_2

I guess at least the commit log should be changed then.


> > Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> > ---
> >   MAINTAINERS                             | 1 +
> >   include/hw/{i386 => southbridge}/ich9.h | 6 +++---
> >   hw/acpi/ich9.c                          | 2 +-
> >   hw/acpi/ich9_tco.c                      | 2 +-
> >   hw/i2c/smbus_ich9.c                     | 2 +-
> >   hw/i386/acpi-build.c                    | 2 +-
> >   hw/i386/pc_q35.c                        | 2 +-
> >   hw/isa/lpc_ich9.c                       | 2 +-
> >   hw/pci-bridge/i82801b11.c               | 2 +-
> >   tests/qtest/tco-test.c                  | 2 +-
> >   10 files changed, 12 insertions(+), 11 deletions(-)
> >   rename include/hw/{i386 => southbridge}/ich9.h (99%)