|
From: | Richard Henderson |
Subject: | Re: [PATCH 1/2] tcg: Clear plugin_mem_cbs on TB exit |
Date: | Thu, 2 Mar 2023 11:16:59 -0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 |
On 3/1/23 02:05, Emilio Cota wrote:
As I mentioned in the patch that is being superseded here I like this approach -- it is simpler and generates less code. I'd also like to see the plugin_gen_disable_mem_helpers function go away, and a mention somewhere that now we are intentionally not clearing cpu->plugin_mem_cbs until TB exit (before we weren't doing that either, but that was unintentional due to a bug). So, for instance when doing a goto_tb from a TB with helpers, we leave plugin_mem_cbs set.
plugin_mem_cbs is used by all out-of-line load/store, therefore we cannot leave it set longer than required.
r~
[Prev in Thread] | Current Thread | [Next in Thread] |