qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4.5 27/29] gdbstub: Adjust gdb_do_syscall to only use uint32


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v4.5 27/29] gdbstub: Adjust gdb_do_syscall to only use uint32_t and uint64_t
Date: Fri, 3 Mar 2023 10:44:49 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0

On 3/3/23 03:58, Richard Henderson wrote:
Pass %x as uint32_t and %lx as uint64_t; pass the address
of %s as uint64_t and the length as uint32_t.

Add casts in semihosting/syscalls.c from target_ulong to
uint64_t; add casts from int to uint32_t for clarity.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
  gdbstub/syscalls.c     | 12 ++++++------
  semihosting/syscalls.c | 34 ++++++++++++++++++++--------------
  2 files changed, 26 insertions(+), 20 deletions(-)

Few more casts, but nice target(_ulong) simplification!

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]