Re: [PATCH 4/6] Add the aehd-ioapic device type.

[Philippe Mathieu-Daudé]

On 3/3/23 03:26, Haitao Shan wrote:
> The aehd-ioapic device type represents the AEHD in kernel IO-APIC.
> The irqchips should be always in kernel when AEHD is used.
>
> Signed-off-by: Haitao Shan <hshan@google.com>
> ---
>   hw/i386/aehd/ioapic.c       | 164 ++++++++++++++++++++++++++++++++++++
>   hw/i386/aehd/meson.build    |   1 +
>   hw/i386/pc.c                |   3 +
>   hw/i386/x86.c               |   3 +
>   include/hw/intc/ioapic.h    |   1 +
>   include/sysemu/aehd.h       |   4 +
>   target/i386/aehd/aehd-all.c |  14 +++
>   7 files changed, 190 insertions(+)
>   create mode 100644 hw/i386/aehd/ioapic.c


> +static const TypeInfo aehd_ioapic_info = {
> +    .name  = TYPE_AEHD_IOAPIC,
> +    .parent = TYPE_IOAPIC_COMMON,

Instead of duplicating TYPE_KVM_IOAPIC, as a first step we should
extract the common code in an abstract TYPE_INKERNEL_IOAPIC object,
then TYPE_AEHD_IOAPIC inherits it.

> +    .instance_size = sizeof(AEHDIOAPICState),
> +    .class_init = aehd_ioapic_class_init,
> +};