Re: [PATCH v2 66/76] target/sparc: Drop get_temp_i32

[Richard Henderson]

On 3/3/23 11:09, Peter Maydell wrote:
> On Mon, 27 Feb 2023 at 05:43, Richard Henderson
> <richard.henderson@linaro.org> wrote:
> > Translators are no longer required to free tcg temporaries,
> > therefore there's no need to record temps for later freeing.
> > Replace the few uses with tcg_temp_new_i32.
> >
> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> > ---
> >   target/sparc/translate.c | 25 ++++---------------------
> >   1 file changed, 4 insertions(+), 21 deletions(-)
>
> Left my review comment on the v1 version of this patch by mistake,
> so just copying it here:
>
> > @@ -5762,14 +5752,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned 
> > int insn)
> >       gen_exception(dc, TT_NCP_INSN);
> >       goto egress;
> >   #endif
> > - egress:
> > -    if (dc->n_t32 != 0) {
> > -        int i;
> > -        for (i = dc->n_t32 - 1; i >= 0; --i) {
> > -            tcg_temp_free_i32(dc->t32[i]);
> > -        }
> > -        dc->n_t32 = 0;
> > -    }
> > + egress:;
> >   }
>
> Stray semicolon after colon, or does C not let you put a label at
> the end of a function ?

Mistaken memory that a label neededs a statement, but
that's to do with declarations not following labels.
I could change it, though it gets removed in the next patch.


r~