RE: [PATCH 1/2] tcg: Link branches to the labels

[Taylor Simpson]

> -----Original Message-----
> From: Richard Henderson <richard.henderson@linaro.org>
> Sent: Friday, March 3, 2023 3:31 PM
> To: qemu-devel@nongnu.org
> Cc: anjo@rev.ng; Taylor Simpson <tsimpson@quicinc.com>
> Subject: [PATCH 1/2] tcg: Link branches to the labels
> 
> This allows us to easily find all branches that use a label.
> Since 'refs' is only tested vs zero, remove it and test for an empty list 
> instead.
> Drop the use of bitfields, which had been used to pack refs into a single 32-
> bit word.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  include/tcg/tcg-op.h |  7 +------
>  include/tcg/tcg.h    | 19 +++++++++++++------
>  tcg/tcg-op.c         | 22 +++++++++++++++++++---
>  tcg/tcg.c            | 30 ++++++++++++++++++++----------
>  4 files changed, 53 insertions(+), 25 deletions(-)
> 
> diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c index f2269a1b91..befc7c000d 100644
> --- a/tcg/tcg-op.c
> +++ b/tcg/tcg-op.c
> @@ -84,6 +84,22 @@ void tcg_gen_op6(TCGOpcode opc, TCGArg a1, TCGArg
> a2, TCGArg a3,
>      op->args[5] = a6;
>  }
> 
> +/* Generic ops.  */
> +
> +static void last_is_label_use(TCGLabel *l) {

It would be more clear to name this function "add_label_use".

Otherwise,
Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>