[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 03/13] hw/pci-host/q35: Use memory_region_set_address() also f
From: |
Bernhard Beschow |
Subject: |
[PATCH v2 03/13] hw/pci-host/q35: Use memory_region_set_address() also for tseg_blackhole |
Date: |
Sat, 4 Mar 2023 16:26:38 +0100 |
Commit bafc90bdc594 ("q35: implement TSEG") uses
memory_region_set_address() for updating the address of mch->tseg_window
but uses memory_region_del_subregion() and
memory_region_add_subregion_overlap() for doing the same on mch-
>tseg_blackhole. The latter seems to be the old, cumbersome
way of changing a memory region's address. So make the code more
comprehensible by modernizing it.
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
hw/pci-host/q35.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
index 40bfe99910..0497194983 100644
--- a/hw/pci-host/q35.c
+++ b/hw/pci-host/q35.c
@@ -404,12 +404,11 @@ static void mch_update_smram(MCHPCIState *mch)
} else {
tseg_size = 0;
}
- memory_region_del_subregion(mch->system_memory, &mch->tseg_blackhole);
+
memory_region_set_enabled(&mch->tseg_blackhole, tseg_size);
memory_region_set_size(&mch->tseg_blackhole, tseg_size);
- memory_region_add_subregion_overlap(mch->system_memory,
- mch->below_4g_mem_size - tseg_size,
- &mch->tseg_blackhole, 1);
+ memory_region_set_address(&mch->tseg_blackhole,
+ mch->below_4g_mem_size - tseg_size);
memory_region_set_enabled(&mch->tseg_window, tseg_size);
memory_region_set_size(&mch->tseg_window, tseg_size);
--
2.39.2
- [PATCH v2 00/13] Q35 PCI host fixes and QOM cleanup, Bernhard Beschow, 2023/03/04
- [PATCH v2 01/13] hw/i386/pc_q35: Resolve redundant q35_host variable, Bernhard Beschow, 2023/03/04
- [PATCH v2 04/13] hw/pci-host/q35: Initialize PCMachineState::bus in board code, Bernhard Beschow, 2023/03/04
- [PATCH v2 05/13] hw/pci/pci_host: Introduce PCI_HOST_BYPASS_IOMMU macro, Bernhard Beschow, 2023/03/04
- [PATCH v2 06/13] hw/pci-host/q35: Initialize "bypass-iommu" property from board code, Bernhard Beschow, 2023/03/04
- [PATCH v2 02/13] hw/pci-host/q35: Fix double, contradicting .endianness assignment, Bernhard Beschow, 2023/03/04
- [PATCH v2 03/13] hw/pci-host/q35: Use memory_region_set_address() also for tseg_blackhole,
Bernhard Beschow <=
- [PATCH v2 07/13] hw/pci-host/q35: Initialize properties just once, Bernhard Beschow, 2023/03/04
- [PATCH v2 08/13] hw/pci-host/q35: Initialize PCI hole boundaries just once, Bernhard Beschow, 2023/03/04
- [PATCH v2 10/13] hw/pci-host/q35: Rename local variable to more idiomatic "phb", Bernhard Beschow, 2023/03/04
- [PATCH v2 09/13] hw/pci-host/q35: Turn PCI hole properties into class properties, Bernhard Beschow, 2023/03/04
- [PATCH v2 11/13] hw/pci-host/q35: Propagate to errp rather than doing error_fatal, Bernhard Beschow, 2023/03/04
- [PATCH v2 12/13] hw/pci-host/q35: Merge mch_realize() into q35_host_realize(), Bernhard Beschow, 2023/03/04
- [PATCH v2 13/13] hw/pci-host/q35: Move MemoryRegion pointers to host device, Bernhard Beschow, 2023/03/04