[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 12/84] tcg: Remove tcg_check_temp_count, tcg_clear_temp_count
From: |
Richard Henderson |
Subject: |
[PULL 12/84] tcg: Remove tcg_check_temp_count, tcg_clear_temp_count |
Date: |
Sun, 5 Mar 2023 16:38:42 -0800 |
Since all temps allocated by guest front-ends are now TEMP_TB,
and we don't recycle TEMP_TB, there's no point in requiring
that the front-ends free the temps at all. Begin by dropping
the inner-most checks that all temps have been freed.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
include/tcg/tcg.h | 14 -----------
accel/tcg/translator.c | 12 ----------
tcg/tcg.c | 54 +++++++-----------------------------------
3 files changed, 8 insertions(+), 72 deletions(-)
diff --git a/include/tcg/tcg.h b/include/tcg/tcg.h
index 0dc88011ce..a5cf21be83 100644
--- a/include/tcg/tcg.h
+++ b/include/tcg/tcg.h
@@ -574,7 +574,6 @@ struct TCGContext {
#endif
#ifdef CONFIG_DEBUG_TCG
- int temps_in_use;
int goto_tb_issue_mask;
const TCGOpcode *vecop_list;
#endif
@@ -965,19 +964,6 @@ static inline TCGv_ptr tcg_temp_new_ptr(void)
return temp_tcgv_ptr(t);
}
-#if defined(CONFIG_DEBUG_TCG)
-/* If you call tcg_clear_temp_count() at the start of a section of
- * code which is not supposed to leak any TCG temporaries, then
- * calling tcg_check_temp_count() at the end of the section will
- * return 1 if the section did in fact leak a temporary.
- */
-void tcg_clear_temp_count(void);
-int tcg_check_temp_count(void);
-#else
-#define tcg_clear_temp_count() do { } while (0)
-#define tcg_check_temp_count() 0
-#endif
-
int64_t tcg_cpu_exec_time(void);
void tcg_dump_info(GString *buf);
void tcg_dump_op_count(GString *buf);
diff --git a/accel/tcg/translator.c b/accel/tcg/translator.c
index d0babfea88..e00e7fa601 100644
--- a/accel/tcg/translator.c
+++ b/accel/tcg/translator.c
@@ -18,17 +18,8 @@
#include "exec/plugin-gen.h"
#include "exec/replay-core.h"
-/* Pairs with tcg_clear_temp_count.
- To be called by #TranslatorOps.{translate_insn,tb_stop} if
- (1) the target is sufficiently clean to support reporting,
- (2) as and when all temporaries are known to be consumed.
- For most targets, (2) is at the end of translate_insn. */
void translator_loop_temp_check(DisasContextBase *db)
{
- if (tcg_check_temp_count()) {
- qemu_log("warning: TCG temporary leaks before "
- TARGET_FMT_lx "\n", db->pc_next);
- }
}
bool translator_use_goto_tb(DisasContextBase *db, target_ulong dest)
@@ -67,9 +58,6 @@ void translator_loop(CPUState *cpu, TranslationBlock *tb, int
*max_insns,
ops->init_disas_context(db, cpu);
tcg_debug_assert(db->is_jmp == DISAS_NEXT); /* no early exit */
- /* Reset the temp count so that we can identify leaks */
- tcg_clear_temp_count();
-
/* Start translating. */
gen_tb_start(db->tb);
ops->tb_start(db, cpu);
diff --git a/tcg/tcg.c b/tcg/tcg.c
index f9e1afd926..e4fccbd0d8 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -1273,7 +1273,7 @@ TCGTemp *tcg_temp_new_internal(TCGType type, TCGTempKind
kind)
ts->temp_allocated = 1;
tcg_debug_assert(ts->base_type == type);
tcg_debug_assert(ts->kind == kind);
- goto done;
+ return ts;
}
} else {
tcg_debug_assert(kind == TEMP_TB);
@@ -1317,11 +1317,6 @@ TCGTemp *tcg_temp_new_internal(TCGType type, TCGTempKind
kind)
ts2->kind = kind;
}
}
-
- done:
-#if defined(CONFIG_DEBUG_TCG)
- s->temps_in_use++;
-#endif
return ts;
}
@@ -1366,30 +1361,18 @@ void tcg_temp_free_internal(TCGTemp *ts)
switch (ts->kind) {
case TEMP_CONST:
- /*
- * In order to simplify users of tcg_constant_*,
- * silently ignore free.
- */
- return;
- case TEMP_EBB:
case TEMP_TB:
+ /* Silently ignore free. */
+ break;
+ case TEMP_EBB:
+ tcg_debug_assert(ts->temp_allocated != 0);
+ ts->temp_allocated = 0;
+ set_bit(temp_idx(ts), s->free_temps[ts->base_type].l);
break;
default:
+ /* It never made sense to free TEMP_FIXED or TEMP_GLOBAL. */
g_assert_not_reached();
}
-
- tcg_debug_assert(ts->temp_allocated != 0);
- ts->temp_allocated = 0;
-
-#if defined(CONFIG_DEBUG_TCG)
- assert(s->temps_in_use > 0);
- s->temps_in_use--;
-#endif
-
- if (ts->kind == TEMP_EBB) {
- int idx = temp_idx(ts);
- set_bit(idx, s->free_temps[ts->base_type].l);
- }
}
TCGTemp *tcg_constant_internal(TCGType type, int64_t val)
@@ -1477,27 +1460,6 @@ TCGv_i64 tcg_const_i64(int64_t val)
return t0;
}
-#if defined(CONFIG_DEBUG_TCG)
-void tcg_clear_temp_count(void)
-{
- TCGContext *s = tcg_ctx;
- s->temps_in_use = 0;
-}
-
-int tcg_check_temp_count(void)
-{
- TCGContext *s = tcg_ctx;
- if (s->temps_in_use) {
- /* Clear the count so that we don't give another
- * warning immediately next time around.
- */
- s->temps_in_use = 0;
- return 1;
- }
- return 0;
-}
-#endif
-
/* Return true if OP may appear in the opcode stream.
Test the runtime variable that controls each opcode. */
bool tcg_op_supported(TCGOpcode op)
--
2.34.1
- [PULL 25/84] target/arm: Drop tcg_temp_free from translator-sme.c, (continued)
- [PULL 25/84] target/arm: Drop tcg_temp_free from translator-sme.c, Richard Henderson, 2023/03/05
- [PULL 26/84] target/arm: Drop tcg_temp_free from translator-sve.c, Richard Henderson, 2023/03/05
- [PULL 24/84] target/arm: Drop tcg_temp_free from translator-neon.c, Richard Henderson, 2023/03/05
- [PULL 27/84] target/arm: Drop tcg_temp_free from translator-vfp.c, Richard Henderson, 2023/03/05
- [PULL 29/84] target/avr: Drop DisasContext.free_skip_var0, Richard Henderson, 2023/03/05
- [PULL 28/84] target/arm: Drop tcg_temp_free from translator.h, Richard Henderson, 2023/03/05
- [PULL 34/84] target/cris: Drop addr from dec10_ind_move_m_pr, Richard Henderson, 2023/03/05
- [PULL 39/84] target/hexagon/idef-parser: Drop HexValue.is_manual, Richard Henderson, 2023/03/05
- [PULL 36/84] target/hexagon: Drop tcg_temp_free from C code, Richard Henderson, 2023/03/05
- [PULL 31/84] target/avr: Drop tcg_temp_free, Richard Henderson, 2023/03/05
- [PULL 12/84] tcg: Remove tcg_check_temp_count, tcg_clear_temp_count,
Richard Henderson <=
- [PULL 32/84] target/cris: Drop cris_alu_free_temps, Richard Henderson, 2023/03/05
- [PULL 35/84] target/cris: Drop tcg_temp_free, Richard Henderson, 2023/03/05
- [PULL 15/84] target/arm: Remove arm_free_cc, a64_free_cc, Richard Henderson, 2023/03/05
- [PULL 21/84] target/arm: Drop tcg_temp_free from translator-a64.c, Richard Henderson, 2023/03/05
- [PULL 23/84] target/arm: Drop tcg_temp_free from translator-mve.c, Richard Henderson, 2023/03/05
- [PULL 33/84] target/cris: Drop cris_alu_m_free_temps, Richard Henderson, 2023/03/05
- [PULL 37/84] target/hexagon: Drop tcg_temp_free from gen_tcg_funcs.py, Richard Henderson, 2023/03/05
- [PULL 38/84] target/hexagon/idef-parser: Drop tcg_temp_free, Richard Henderson, 2023/03/05
- [PULL 20/84] target/arm: Drop new_tmp_a64_zero, Richard Henderson, 2023/03/05
- [PULL 42/84] target/loongarch: Drop tcg_temp_free, Richard Henderson, 2023/03/05