[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 03/27] audio: don't show unnecessary error messages
From: |
marcandre . lureau |
Subject: |
[PULL 03/27] audio: don't show unnecessary error messages |
Date: |
Mon, 6 Mar 2023 10:51:38 +0400 |
From: Volker Rümelin <vr_qemu@t-online.de>
Let the audio_pcm_create_voice_pair_* functions handle error
reporting. This avoids an additional error message in case
the guest selected an unimplemented sample rate.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20230121094735.11644-2-vr_qemu@t-online.de>
---
audio/audio_template.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/audio/audio_template.h b/audio/audio_template.h
index dbfb4fee4c..f0ef262ab3 100644
--- a/audio/audio_template.h
+++ b/audio/audio_template.h
@@ -441,6 +441,7 @@ static SW *glue(audio_pcm_create_voice_pair_, TYPE)(
hw = glue(audio_pcm_hw_add_, TYPE)(s, &hw_as);
if (!hw) {
+ dolog("Could not create a backend for voice `%s'\n", sw_name);
goto err2;
}
@@ -540,7 +541,6 @@ SW *glue (AUD_open_, TYPE) (
} else {
sw = glue(audio_pcm_create_voice_pair_, TYPE)(s, name, as);
if (!sw) {
- dolog ("Failed to create voice `%s'\n", name);
return NULL;
}
}
--
2.39.2
- [PULL 00/27] Audio patches, marcandre . lureau, 2023/03/06
- [PULL 03/27] audio: don't show unnecessary error messages,
marcandre . lureau <=
- [PULL 02/27] audio: log unimplemented audio device sample rates, marcandre . lureau, 2023/03/06
- [PULL 01/27] MAINTAINERS: add myself to ui/ and audio/, marcandre . lureau, 2023/03/06
- [PULL 04/27] audio: rename hardware store to backend, marcandre . lureau, 2023/03/06
- [PULL 05/27] audio: remove unused #define AUDIO_STRINGIFY, marcandre . lureau, 2023/03/06
- [PULL 06/27] audio/mixeng: use g_new0() instead of audio_calloc(), marcandre . lureau, 2023/03/06
- [PULL 09/27] audio/audio_template: use g_new0() to replace audio_calloc(), marcandre . lureau, 2023/03/06
- [PULL 07/27] audio/alsaaudio: use g_new0() instead of audio_calloc(), marcandre . lureau, 2023/03/06
- [PULL 10/27] audio: remove audio_calloc() function, marcandre . lureau, 2023/03/06
- [PULL 08/27] audio/audio_template: use g_malloc0() to replace audio_calloc(), marcandre . lureau, 2023/03/06
- [PULL 11/27] alsaaudio: change default playback settings, marcandre . lureau, 2023/03/06