[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 12/16] tests/qtest/readconfig-test: Allow testing for arbitrary me
From: |
Thomas Huth |
Subject: |
[PULL 12/16] tests/qtest/readconfig-test: Allow testing for arbitrary memory sizes |
Date: |
Mon, 6 Mar 2023 14:29:58 +0100 |
Make test_x86_memdev_resp() more flexible by allowing arbitrary
memory sizes as parameter here.
Message-Id: <20230228211533.201837-5-thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qtest/readconfig-test.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/qtest/readconfig-test.c b/tests/qtest/readconfig-test.c
index 2160603880..533623f638 100644
--- a/tests/qtest/readconfig-test.c
+++ b/tests/qtest/readconfig-test.c
@@ -48,7 +48,7 @@ static QTestState *qtest_init_with_config(const char *cfgdata)
return qts;
}
-static void test_x86_memdev_resp(QObject *res)
+static void test_x86_memdev_resp(QObject *res, const char *mem_id, int size)
{
Visitor *v;
g_autoptr(MemdevList) memdevs = NULL;
@@ -63,8 +63,8 @@ static void test_x86_memdev_resp(QObject *res)
g_assert(!memdevs->next);
memdev = memdevs->value;
- g_assert_cmpstr(memdev->id, ==, "ram");
- g_assert_cmpint(memdev->size, ==, 200 * MiB);
+ g_assert_cmpstr(memdev->id, ==, mem_id);
+ g_assert_cmpint(memdev->size, ==, size * MiB);
visit_free(v);
}
@@ -80,7 +80,7 @@ static void test_x86_memdev(void)
qts = qtest_init_with_config(cfgdata);
/* Test valid command */
resp = qtest_qmp(qts, "{ 'execute': 'query-memdev' }");
- test_x86_memdev_resp(qdict_get(resp, "return"));
+ test_x86_memdev_resp(qdict_get(resp, "return"), "ram", 200);
qobject_unref(resp);
qtest_quit(qts);
--
2.31.1
- [PULL 00/16] Final tests, s390x and misc updates before the soft freeze, Thomas Huth, 2023/03/06
- [PULL 06/16] gitlab-ci.d/crossbuilds: Drop the i386 system emulation job, Thomas Huth, 2023/03/06
- [PULL 09/16] tests/qtest/readconfig: Rework test_object_rng_resp into a generic function, Thomas Huth, 2023/03/06
- [PULL 11/16] docs/config: Set the "kvm" accelerator via "[accel]" section, Thomas Huth, 2023/03/06
- [PULL 07/16] docs/about/deprecated: Deprecate 32-bit arm hosts for system emulation, Thomas Huth, 2023/03/06
- [PULL 02/16] Hexagon (meson.build): define min bison version, Thomas Huth, 2023/03/06
- [PULL 01/16] docs/about/build-platforms: Refine the distro support policy, Thomas Huth, 2023/03/06
- [PULL 03/16] test: Check vnc enable before compiling vnc test, Thomas Huth, 2023/03/06
- [PULL 10/16] tests/qtest/readconfig: Test docs/config/ich9-ehci-uhci.cfg, Thomas Huth, 2023/03/06
- [PULL 12/16] tests/qtest/readconfig-test: Allow testing for arbitrary memory sizes,
Thomas Huth <=
- [PULL 13/16] tests/qtest: Move mkimg() and have_qemu_img() from libqos to libqtest, Thomas Huth, 2023/03/06
- [PULL 08/16] gitlab-ci.d/crossbuilds: Drop the 32-bit arm system emulation jobs, Thomas Huth, 2023/03/06
- [PULL 05/16] docs/about/deprecated: Deprecate 32-bit x86 hosts for system emulation, Thomas Huth, 2023/03/06
- [PULL 14/16] tests/qtest/readconfig: Test docs/config/q35-emulated.cfg, Thomas Huth, 2023/03/06
- [PULL 16/16] pc-bios/s390-ccw: Update s390-ccw.img with the list-directed IPL fix, Thomas Huth, 2023/03/06
- [PULL 04/16] include/hw/i386: Clean up includes in x86.h, Thomas Huth, 2023/03/06
- [PULL 15/16] pc-bios: Add support for List-Directed IPL from ECKD DASD, Thomas Huth, 2023/03/06
- Re: [PULL 00/16] Final tests, s390x and misc updates before the soft freeze, Peter Maydell, 2023/03/07