[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/8] edu: add smp_mb__after_rmw()
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH 4/8] edu: add smp_mb__after_rmw() |
|
Date: |
Mon, 6 Mar 2023 13:38:45 +0000 |
On Fri, 3 Mar 2023 at 17:21, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> Ensure ordering between clearing the COMPUTING flag and checking
> IRQFACT, and between setting the IRQFACT flag and checking
> COMPUTING. This ensures that no wakeups are lost.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Why is this device even messing around with multiple
threads and atomics anyway ??
I'm quite tempted to suggest we should deprecate-and-drop
this; it's not real hardware, it doesn't do anything
useful, and it's not a good model to follow if you're
implementing some other device.
thanks
-- PMM
- Re: [PATCH 2/8] qemu-thread-posix: cleanup, fix, document QemuEvent, (continued)
- [PATCH 3/8] qemu-thread-win32: cleanup, fix, document QemuEvent, Paolo Bonzini, 2023/03/03
- Re: [PATCH 3/8] qemu-thread-win32: cleanup, fix, document QemuEvent, Richard Henderson, 2023/03/05
- Re: [PATCH 3/8] qemu-thread-win32: cleanup, fix, document QemuEvent, David Hildenbrand, 2023/03/06
- Re: [PATCH 3/8] qemu-thread-win32: cleanup, fix, document QemuEvent, Paolo Bonzini, 2023/03/06
- Re: [PATCH 3/8] qemu-thread-win32: cleanup, fix, document QemuEvent, David Hildenbrand, 2023/03/06
- Re: [PATCH 3/8] qemu-thread-win32: cleanup, fix, document QemuEvent, Paolo Bonzini, 2023/03/06
[PATCH 4/8] edu: add smp_mb__after_rmw(), Paolo Bonzini, 2023/03/03
[PATCH 5/8] util/async: add smp_mb__after_rmw() around BH enqueue/dequeue, Paolo Bonzini, 2023/03/03
[PATCH 6/8] aio-wait: switch to smp_mb__after_rmw(), Paolo Bonzini, 2023/03/03