qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/4] linux-user: fix sockaddr_in6 endianness


From: Laurent Vivier
Subject: Re: [PATCH v2 2/4] linux-user: fix sockaddr_in6 endianness
Date: Mon, 6 Mar 2023 22:52:16 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0

Le 20/02/2023 à 09:58, Mathis Marion a écrit :
From: Mathis Marion <mathis.marion@silabs.com>

Fields sin6_flowinfo and sin6_scope_id use the host byte order, so there
is a conversion to be made when host and target endianness differ.

Signed-off-by: Mathis Marion <mathis.marion@silabs.com>
---
  linux-user/syscall.c | 6 ++++++
  1 file changed, 6 insertions(+)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 58549de125..1a6856abec 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -1713,6 +1713,12 @@ static inline abi_long target_to_host_sockaddr(int fd, 
struct sockaddr *addr,
        lladdr = (struct target_sockaddr_ll *)addr;
        lladdr->sll_ifindex = tswap32(lladdr->sll_ifindex);
        lladdr->sll_hatype = tswap16(lladdr->sll_hatype);
+    } else if (sa_family == AF_INET6) {
+        struct sockaddr_in6 *in6addr;
+
+        in6addr = (struct sockaddr_in6 *)addr;
+        in6addr->sin6_flowinfo = tswap32(in6addr->sin6_flowinfo);

In /usr/include/linux/in6.h, it's defined as a __be32, so I don't think we need to change its endianness.

+        in6addr->sin6_scope_id = tswap32(in6addr->sin6_scope_id);
      }
      unlock_user(target_saddr, target_addr, 0);




reply via email to

[Prev in Thread] Current Thread [Next in Thread]