[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 02/25] target/arm: Handle FPROUNDING_ODD in arm_rmode_to_sf
From: |
Richard Henderson |
Subject: |
[PATCH v2 02/25] target/arm: Handle FPROUNDING_ODD in arm_rmode_to_sf |
Date: |
Tue, 7 Mar 2023 10:34:40 -0800 |
While this enumerator has been present since the first commit,
it isn't ever used. The first actual use of round-to-odd came
with SVE, which currently uses float_round_to_odd instead of
the arm-specific enumerator.
Amusingly, the comment about unhandled TIEAWAY has been
out of date since the initial commit of translate-a64.c.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
Cc: qemu-arm@nongnu.org
---
target/arm/vfp_helper.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/target/arm/vfp_helper.c b/target/arm/vfp_helper.c
index 24e3d820a5..90cc324f71 100644
--- a/target/arm/vfp_helper.c
+++ b/target/arm/vfp_helper.c
@@ -1111,10 +1111,8 @@ int arm_rmode_to_sf(int rmode)
rmode = float_round_ties_away;
break;
case FPROUNDING_ODD:
- /* FIXME: add support for TIEAWAY and ODD */
- qemu_log_mask(LOG_UNIMP, "arm: unimplemented rounding mode: %d\n",
- rmode);
- /* fall through for now */
+ rmode = float_round_to_odd;
+ break;
case FPROUNDING_TIEEVEN:
default:
rmode = float_round_nearest_even;
--
2.34.1
- [PATCH v2 00/25] tcg: Remove tcg_const_*, Richard Henderson, 2023/03/07
- [PATCH v2 02/25] target/arm: Handle FPROUNDING_ODD in arm_rmode_to_sf,
Richard Henderson <=
- [PATCH v2 01/25] target/arm: Use rmode >= 0 for need_rmode, Richard Henderson, 2023/03/07
- [PATCH v2 03/25] target/arm: Improve arm_rmode_to_sf, Richard Henderson, 2023/03/07
- [PATCH v2 04/25] target/arm: Consistently use ARMFPRounding during translation, Richard Henderson, 2023/03/07
- [PATCH v2 05/25] target/arm: Create gen_set_rmode, gen_restore_rmode, Richard Henderson, 2023/03/07
- [PATCH v2 06/25] target/arm: Improve trans_BFCI, Richard Henderson, 2023/03/07
- [PATCH v2 07/25] target/arm: Avoid tcg_const_ptr in gen_sve_{ldr, str}, Richard Henderson, 2023/03/07
- [PATCH v2 08/25] target/arm: Avoid tcg_const_* in translate-mve.c, Richard Henderson, 2023/03/07