Re: [PATCH v2 0/2] MIPS Virt machine

[Philippe Mathieu-Daudé]

On 7/3/23 21:07, Jiaxun Yang wrote:
> > 2023年3月7日 15:01，Philippe Mathieu-Daudé <philmd@linaro.org> 写道：
> >
> > On 4/3/23 23:38, Jiaxun Yang wrote:
> > > Hi there,
> > > This patchset is to add a new machine type for MIPS architecture, which
> > > is purely a VirtIO machine.
> >
> > > Jiaxun Yang (2):
> > >   hw/misc: Add MIPS Trickbox device
> > >   hw/mips: Add MIPS virt board
> > Thanks, applied with following changes:
>
> Thanks for those clean-ups!
>
> > - remove pointless mask in mips_trickbox_write(),
> > - declare QOM macros using OBJECT_DECLARE_SIMPLE_TYPE(),
> > - declare machine type using DEFINE_TYPES(),
> > - do not select PCI in Kconfig,
>
> Hmm, PCI is sort of mandatory for this machine, any reason not to select it?

The machine itself doesn't expose a PCI bus directly, it
is exposed by the PCI_EXPRESS_GENERIC_BRIDGE.

We have PCI_EXPRESS_GENERIC_BRIDGE -> PCI_EXPRESS -> PCI.