[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 1/3] qga: Refactor guest-exec capture-output to take enum
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH v5 1/3] qga: Refactor guest-exec capture-output to take enum |
|
Date: |
Fri, 10 Mar 2023 09:20:09 +0000 |
|
User-agent: |
Mutt/2.2.9 (2022-11-12) |
On Thu, Mar 09, 2023 at 03:40:56PM -0700, Daniel Xu wrote:
> Previously capture-output was an optional boolean flag that either
> captured all output or captured none. While this is OK in most cases, it
> lacks flexibility for more advanced capture cases, such as wanting to
> only capture stdout.
>
> This commits refactors guest-exec qapi to take an enum for capture mode
> instead while preserving backwards compatibility.
>
> Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
> ---
> qga/commands.c | 37 ++++++++++++++++++++++++++++++++++---
> qga/qapi-schema.json | 33 ++++++++++++++++++++++++++++++++-
> 2 files changed, 66 insertions(+), 4 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|