Re: [PATCH 11/11] tests/avocado: don't use tags to define drive

[Philippe Mathieu-Daudé]

On 10/3/23 11:31, Alex Bennée wrote:
> We are abusing the avocado tags which are intended to provide test
> selection metadata to provide parameters to our test.

Oh I missed that, good point.

> This works OK up
> until the point you need to have ,'s in the field as this is the tag
> separator character which is the case for a number of the drive
> parameters. Fix this by making drive a parameter to the common helper
> function.
>
> Fixes: 267fe57c23 (tests: add tuxrun baseline test to avocado)
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: David Woodhouse <dwmw2@infradead.org>
> ---
>   tests/avocado/tuxrun_baselines.py | 60 +++++++++++++------------------
>   1 file changed, 24 insertions(+), 36 deletions(-)

These also need to be cleaned:

>           :avocado: tags=tuxboot:armv5
>           :avocado: tags=image:zImage
>           :avocado: tags=console:ttyAMA0
>           :avocado: tags=root:sda
>           :avocado: tags=shutdown:nowait
>           :avocado: tags=extradev:driver=spapr-vscsi

Can be done on top, so:

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>