Re: [PULL 00/73] virtio,pc,pci: features, fixes

[Philippe Mathieu-Daudé]

On 11/3/23 20:22, Michael S. Tsirkin wrote:
> On Fri, Mar 10, 2023 at 11:20:36PM +0100, Philippe Mathieu-Daudé wrote:
> > Hi,
> >
> > On 10/3/23 18:32, Peter Maydell wrote:
> > > On Thu, 9 Mar 2023 at 14:47, Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > > > I moved it one commit back, now at (96cb085897)
> > > > Cornelia posted some concerns about the last commit.
> > > >
> > > > > ----------------------------------------------------------------
> > > > > virtio,pc,pci: features, fixes
> > > > >
> > > > > Several features that landed at the last possible moment:
> > > > >
> > > > > Passthrough HDM decoder emulation
> > > > > Refactor cryptodev
> > > > > RAS error emulation and injection
> > > > > acpi-index support on non-hotpluggable slots
> > > > > Dynamically switch to vhost shadow virtqueues at vdpa net migration
> > > > >
> > > > > Plus a couple of bugfixes that look important to have in the release.
> > > > >
> > > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > >
> > >
> > > Applied, thanks.
> >
> > I'm getting this failure on Darwin (m1):
> >
> > C compiler for the host machine: clang (clang 14.0.0 "Apple clang version
> > 14.0.0 (clang-1400.0.29.202)")
> > Program iasl found: YES (/opt/homebrew/bin/iasl)
> >
> > $ make check-qtest-i386 V=1
> >   ...
> >   3/61 qemu:qtest+qtest-i386 / qtest-i386/bios-tables-test ERROR
> > 17.52s   killed by signal 6 SIGABRT
> > ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
> > ✀ 
> > ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
> > stderr:
> > acpi-test: Warning! DSDT binary file mismatch. Actual
> > [aml:/var/folders/yj/r7khncsj4d77k04ybz9lw4tm0000gn/T/aml-HANQ11], Expected
> > [aml:tests/data/acpi/pc/DSDT.nosmm].
>
> Philippe, is tests/data/acpi/DSDT.nosmm in your tree for some reason?
> Because it's not in mine:
> $ git log -- tests/data/acpi/DSDT.nosmm
>
>
> It's a side effect of how our tests work ATM that a presence of
> a corrupted file in the source directory will confuse the test
> and make it fail, and git reset will not be enough since some
> of these can be untracked - you need git clean.

Indeed 'git status' shows:

        tests/data/acpi/microvm/APIC.rtc
        tests/data/acpi/microvm/APIC.usb
        tests/data/acpi/microvm/FACP.ioapic2
        tests/data/acpi/microvm/FACP.pcie
        tests/data/acpi/microvm/FACP.rtc
        tests/data/acpi/microvm/FACP.usb
        tests/data/acpi/pc/APIC.acpierst
        tests/data/acpi/pc/APIC.bridge
        tests/data/acpi/pc/APIC.hpbridge
        tests/data/acpi/pc/APIC.hpbrroot
        tests/data/acpi/pc/APIC.ipmikcs
        tests/data/acpi/pc/APIC.memhp
        tests/data/acpi/pc/APIC.nohpet
        tests/data/acpi/pc/APIC.nosmm
        tests/data/acpi/pc/APIC.numamem
        tests/data/acpi/pc/APIC.roothp
        tests/data/acpi/pc/APIC.smm-compat
        tests/data/acpi/pc/APIC.smm-compat-nosmm
        tests/data/acpi/pc/DSDT.nosmm
        tests/data/acpi/pc/DSDT.smm-compat
        tests/data/acpi/pc/DSDT.smm-compat-nosmm
        tests/data/acpi/pc/FACP.acpierst
        tests/data/acpi/pc/FACP.acpihmat
        tests/data/acpi/pc/FACP.bridge
        tests/data/acpi/pc/FACP.cphp
        tests/data/acpi/pc/FACP.dimmpxm
        tests/data/acpi/pc/FACP.hpbridge
        tests/data/acpi/pc/FACP.hpbrroot
        tests/data/acpi/pc/FACP.ipmikcs
        tests/data/acpi/pc/FACP.memhp
        tests/data/acpi/pc/FACP.nohpet
        tests/data/acpi/pc/FACP.numamem
        tests/data/acpi/pc/FACP.roothp
        tests/data/acpi/pc/FACP.smm-compat
        tests/data/acpi/pc/FACP.smm-compat-nosmm
        tests/data/acpi/pc/FACS.acpierst
        tests/data/acpi/pc/FACS.acpihmat
        tests/data/acpi/pc/FACS.bridge
        tests/data/acpi/pc/FACS.cphp
        tests/data/acpi/pc/FACS.dimmpxm
        tests/data/acpi/pc/FACS.hpbridge
        tests/data/acpi/pc/FACS.hpbrroot
        tests/data/acpi/pc/FACS.ipmikcs
        tests/data/acpi/pc/FACS.memhp
        tests/data/acpi/pc/FACS.nohpet
        tests/data/acpi/pc/FACS.nosmm
        tests/data/acpi/pc/FACS.numamem
        tests/data/acpi/pc/FACS.roothp
        tests/data/acpi/pc/FACS.smm-compat
        tests/data/acpi/pc/FACS.smm-compat-nosmm
        tests/data/acpi/pc/HPET.acpierst
        tests/data/acpi/pc/HPET.acpihmat
        tests/data/acpi/pc/HPET.bridge
        tests/data/acpi/pc/HPET.cphp
        tests/data/acpi/pc/HPET.dimmpxm
        tests/data/acpi/pc/HPET.hpbridge
        tests/data/acpi/pc/HPET.hpbrroot
        tests/data/acpi/pc/HPET.ipmikcs
        tests/data/acpi/pc/HPET.memhp
        tests/data/acpi/pc/HPET.nosmm
        tests/data/acpi/pc/HPET.numamem
        tests/data/acpi/pc/HPET.roothp
        tests/data/acpi/pc/HPET.smm-compat
        tests/data/acpi/pc/HPET.smm-compat-nosmm
        tests/data/acpi/pc/WAET.acpierst
        tests/data/acpi/pc/WAET.acpihmat
        tests/data/acpi/pc/WAET.bridge
        tests/data/acpi/pc/WAET.cphp
        tests/data/acpi/pc/WAET.dimmpxm
        tests/data/acpi/pc/WAET.hpbridge
        tests/data/acpi/pc/WAET.hpbrroot
        tests/data/acpi/pc/WAET.ipmikcs
        tests/data/acpi/pc/WAET.memhp
        tests/data/acpi/pc/WAET.nohpet
        tests/data/acpi/pc/WAET.nosmm
        tests/data/acpi/pc/WAET.numamem
        tests/data/acpi/pc/WAET.roothp
        tests/data/acpi/pc/WAET.smm-compat
        tests/data/acpi/pc/WAET.smm-compat-nosmm
        tests/data/acpi/q35/APIC.acpierst
        tests/data/acpi/q35/APIC.applesmc
        tests/data/acpi/q35/APIC.bridge
        tests/data/acpi/q35/APIC.cxl
        tests/data/acpi/q35/APIC.ipmibt
        tests/data/acpi/q35/APIC.ipmismbus
        tests/data/acpi/q35/APIC.ivrs
        tests/data/acpi/q35/APIC.memhp
        tests/data/acpi/q35/APIC.mmio64
        tests/data/acpi/q35/APIC.multi-bridge
        tests/data/acpi/q35/APIC.noacpihp
        tests/data/acpi/q35/APIC.nohpet
        tests/data/acpi/q35/APIC.nosmm
        tests/data/acpi/q35/APIC.numamem
        tests/data/acpi/q35/APIC.pvpanic-isa
        tests/data/acpi/q35/APIC.slic
        tests/data/acpi/q35/APIC.smm-compat
        tests/data/acpi/q35/APIC.smm-compat-nosmm
        tests/data/acpi/q35/APIC.tis.tpm12
        tests/data/acpi/q35/APIC.tis.tpm2
        tests/data/acpi/q35/APIC.viot
        tests/data/acpi/q35/DSDT.dsl
        tests/data/acpi/q35/DSDT.nosmm
        tests/data/acpi/q35/DSDT.slic
        tests/data/acpi/q35/DSDT.smm-compat
        tests/data/acpi/q35/DSDT.smm-compat-nosmm
        tests/data/acpi/q35/FACP.acpierst
        tests/data/acpi/q35/FACP.acpihmat
        tests/data/acpi/q35/FACP.acpihmat-noinitiator
        tests/data/acpi/q35/FACP.applesmc
        tests/data/acpi/q35/FACP.bridge
        tests/data/acpi/q35/FACP.cphp
        tests/data/acpi/q35/FACP.cxl
        tests/data/acpi/q35/FACP.dimmpxm
        tests/data/acpi/q35/FACP.ipmibt
        tests/data/acpi/q35/FACP.ipmismbus
        tests/data/acpi/q35/FACP.ivrs
        tests/data/acpi/q35/FACP.memhp
        tests/data/acpi/q35/FACP.mmio64
        tests/data/acpi/q35/FACP.multi-bridge
        tests/data/acpi/q35/FACP.noacpihp
        tests/data/acpi/q35/FACP.nohpet
        tests/data/acpi/q35/FACP.numamem
        tests/data/acpi/q35/FACP.pvpanic-isa
        tests/data/acpi/q35/FACP.smm-compat
        tests/data/acpi/q35/FACP.smm-compat-nosmm
        tests/data/acpi/q35/FACP.tis.tpm12
        tests/data/acpi/q35/FACP.tis.tpm2
        tests/data/acpi/q35/FACP.viot
        tests/data/acpi/q35/FACS.acpierst
        tests/data/acpi/q35/FACS.acpihmat
        tests/data/acpi/q35/FACS.acpihmat-noinitiator
        tests/data/acpi/q35/FACS.applesmc
        tests/data/acpi/q35/FACS.bridge
        tests/data/acpi/q35/FACS.cphp
        tests/data/acpi/q35/FACS.cxl
        tests/data/acpi/q35/FACS.dimmpxm
        tests/data/acpi/q35/FACS.ipmibt
        tests/data/acpi/q35/FACS.ipmismbus
        tests/data/acpi/q35/FACS.ivrs
        tests/data/acpi/q35/FACS.memhp
        tests/data/acpi/q35/FACS.mmio64
        tests/data/acpi/q35/FACS.multi-bridge
        tests/data/acpi/q35/FACS.noacpihp
        tests/data/acpi/q35/FACS.nohpet
        tests/data/acpi/q35/FACS.nosmm
        tests/data/acpi/q35/FACS.numamem
        tests/data/acpi/q35/FACS.pvpanic-isa
        tests/data/acpi/q35/FACS.slic
        tests/data/acpi/q35/FACS.smm-compat
        tests/data/acpi/q35/FACS.smm-compat-nosmm
        tests/data/acpi/q35/FACS.tis.tpm12
        tests/data/acpi/q35/FACS.tis.tpm2
        tests/data/acpi/q35/FACS.viot
        tests/data/acpi/q35/HPET.acpierst
        tests/data/acpi/q35/HPET.acpihmat
        tests/data/acpi/q35/HPET.acpihmat-noinitiator
        tests/data/acpi/q35/HPET.applesmc
        tests/data/acpi/q35/HPET.bridge
        tests/data/acpi/q35/HPET.cphp
        tests/data/acpi/q35/HPET.cxl
        tests/data/acpi/q35/HPET.dimmpxm
        tests/data/acpi/q35/HPET.ipmibt
        tests/data/acpi/q35/HPET.ipmismbus
        tests/data/acpi/q35/HPET.ivrs
        tests/data/acpi/q35/HPET.memhp
        tests/data/acpi/q35/HPET.mmio64
        tests/data/acpi/q35/HPET.multi-bridge
        tests/data/acpi/q35/HPET.noacpihp
        tests/data/acpi/q35/HPET.nosmm
        tests/data/acpi/q35/HPET.numamem
        tests/data/acpi/q35/HPET.pvpanic-isa
        tests/data/acpi/q35/HPET.slic
        tests/data/acpi/q35/HPET.smm-compat
        tests/data/acpi/q35/HPET.smm-compat-nosmm
        tests/data/acpi/q35/HPET.tis.tpm12
        tests/data/acpi/q35/HPET.tis.tpm2
        tests/data/acpi/q35/HPET.viot
        tests/data/acpi/q35/MCFG.acpierst
        tests/data/acpi/q35/MCFG.acpihmat
        tests/data/acpi/q35/MCFG.acpihmat-noinitiator
        tests/data/acpi/q35/MCFG.applesmc
        tests/data/acpi/q35/MCFG.bridge
        tests/data/acpi/q35/MCFG.cphp
        tests/data/acpi/q35/MCFG.cxl
        tests/data/acpi/q35/MCFG.dimmpxm
        tests/data/acpi/q35/MCFG.ipmibt
        tests/data/acpi/q35/MCFG.ipmismbus
        tests/data/acpi/q35/MCFG.ivrs
        tests/data/acpi/q35/MCFG.memhp
        tests/data/acpi/q35/MCFG.mmio64
        tests/data/acpi/q35/MCFG.multi-bridge
        tests/data/acpi/q35/MCFG.noacpihp
        tests/data/acpi/q35/MCFG.nohpet
        tests/data/acpi/q35/MCFG.nosmm
        tests/data/acpi/q35/MCFG.numamem
        tests/data/acpi/q35/MCFG.pvpanic-isa
        tests/data/acpi/q35/MCFG.slic
        tests/data/acpi/q35/MCFG.smm-compat
        tests/data/acpi/q35/MCFG.smm-compat-nosmm
        tests/data/acpi/q35/MCFG.tis.tpm12
        tests/data/acpi/q35/MCFG.tis.tpm2
        tests/data/acpi/q35/MCFG.viot
        tests/data/acpi/q35/WAET.acpierst
        tests/data/acpi/q35/WAET.acpihmat
        tests/data/acpi/q35/WAET.acpihmat-noinitiator
        tests/data/acpi/q35/WAET.applesmc
        tests/data/acpi/q35/WAET.bridge
        tests/data/acpi/q35/WAET.cphp
        tests/data/acpi/q35/WAET.cxl
        tests/data/acpi/q35/WAET.dimmpxm
        tests/data/acpi/q35/WAET.ipmibt
        tests/data/acpi/q35/WAET.ipmismbus
        tests/data/acpi/q35/WAET.ivrs
        tests/data/acpi/q35/WAET.memhp
        tests/data/acpi/q35/WAET.mmio64
        tests/data/acpi/q35/WAET.multi-bridge
        tests/data/acpi/q35/WAET.noacpihp
        tests/data/acpi/q35/WAET.nohpet
        tests/data/acpi/q35/WAET.nosmm
        tests/data/acpi/q35/WAET.numamem
        tests/data/acpi/q35/WAET.pvpanic-isa
        tests/data/acpi/q35/WAET.slic
        tests/data/acpi/q35/WAET.smm-compat
        tests/data/acpi/q35/WAET.smm-compat-nosmm
        tests/data/acpi/q35/WAET.tis.tpm12
        tests/data/acpi/q35/WAET.tis.tpm2
        tests/data/acpi/q35/WAET.viot
        tests/data/acpi/virt/APIC.memhp
        tests/data/acpi/virt/APIC.numamem
        tests/data/acpi/virt/APIC.pxb
        tests/data/acpi/virt/DBG2.acpihmatvirt
        tests/data/acpi/virt/DBG2.memhp
        tests/data/acpi/virt/DBG2.numamem
        tests/data/acpi/virt/DBG2.pxb
        tests/data/acpi/virt/DBG2.topology
        tests/data/acpi/virt/DSDT.numamem
        tests/data/acpi/virt/FACP.acpihmatvirt
        tests/data/acpi/virt/FACP.memhp
        tests/data/acpi/virt/FACP.numamem
        tests/data/acpi/virt/FACP.pxb
        tests/data/acpi/virt/FACP.topology
        tests/data/acpi/virt/GTDT.acpihmatvirt
        tests/data/acpi/virt/GTDT.memhp
        tests/data/acpi/virt/GTDT.numamem
        tests/data/acpi/virt/GTDT.pxb
        tests/data/acpi/virt/GTDT.topology
        tests/data/acpi/virt/IORT.acpihmatvirt
        tests/data/acpi/virt/IORT.memhp
        tests/data/acpi/virt/IORT.numamem
        tests/data/acpi/virt/IORT.pxb
        tests/data/acpi/virt/IORT.topology
        tests/data/acpi/virt/MCFG.acpihmatvirt
        tests/data/acpi/virt/MCFG.memhp
        tests/data/acpi/virt/MCFG.numamem
        tests/data/acpi/virt/MCFG.pxb
        tests/data/acpi/virt/MCFG.topology
        tests/data/acpi/virt/PPTT.memhp
        tests/data/acpi/virt/PPTT.numamem
        tests/data/acpi/virt/PPTT.pxb
        tests/data/acpi/virt/SPCR.acpihmatvirt
        tests/data/acpi/virt/SPCR.memhp
        tests/data/acpi/virt/SPCR.numamem
        tests/data/acpi/virt/SPCR.pxb
        tests/data/acpi/virt/SPCR.topology

Tests pass after removing all of them. I forgot to check their
timestamp before removing, so I don't know how/when they appeared
in my source directory...