qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 6/6] lsi53c895a: disable reentrancy detection for script R


From: Thomas Huth
Subject: Re: [PATCH v7 6/6] lsi53c895a: disable reentrancy detection for script RAM
Date: Mon, 13 Mar 2023 09:38:01 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0

On 13/03/2023 09.24, Alexander Bulekov wrote:
As the code is designed to use the memory APIs to access the script ram,
disable reentrancy checks for the pseudo-RAM ram_io MemoryRegion.

In the future, ram_io may be converted from an IO to a proper RAM MemoryRegion.

Reported-by: Fiona Ebner <f.ebner@proxmox.com>
Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
---
  hw/scsi/lsi53c895a.c | 6 ++++++
  1 file changed, 6 insertions(+)

diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c
index af93557a9a..db27872963 100644
--- a/hw/scsi/lsi53c895a.c
+++ b/hw/scsi/lsi53c895a.c
@@ -2302,6 +2302,12 @@ static void lsi_scsi_realize(PCIDevice *dev, Error 
**errp)
      memory_region_init_io(&s->io_io, OBJECT(s), &lsi_io_ops, s,
                            "lsi-io", 256);
+ /*
+     * Since we use the address-space API to interact with ram_io, disable the
+     * re-entrancy guard.
+     */
+    s->ram_io.disable_reentrancy_guard = true;
+
      address_space_init(&s->pci_io_as, pci_address_space_io(dev), 
"lsi-pci-io");
      qdev_init_gpio_out(d, &s->ext_irq, 1);

Reviewed-by: Thomas Huth <thuth@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]