Re: [PATCH] migration/rdma: Remove deprecated variable rdma_return_path

[Juan Quintela]

"lizhijian@fujitsu.com" <lizhijian@fujitsu.com> wrote:
> Not clear why it doesn't appear in the 
> archive(https://lists.gnu.org/archive/html/qemu-devel/2023-03/threads.html)

No clue either.

> nop...




>
>
> On 15/03/2023 09:22, Li Zhijian wrote:
>> It's no longer needed since commit
>> 44bcfd45e98 ("migration/rdma: destination: create the return patch after the 
>> first accept")
>> 
>> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
>> ---
>>   migration/rdma.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>> 
>> diff --git a/migration/rdma.c b/migration/rdma.c
>> index f5d3bbe7e9c..2bc2fcf727b 100644
>> --- a/migration/rdma.c
>> +++ b/migration/rdma.c
>> @@ -4214,7 +4214,7 @@ static void rdma_accept_incoming_migration(void 
>> *opaque)
>>   void rdma_start_incoming_migration(const char *host_port, Error **errp)
>>   {
>>       int ret;
>> -    RDMAContext *rdma, *rdma_return_path = NULL;
>> +    RDMAContext *rdma;
>>       Error *local_err = NULL;
>>   
>>       trace_rdma_start_incoming_migration();
>> @@ -4260,7 +4260,6 @@ err:
>>           g_free(rdma->host_port);
>>       }
>>       g_free(rdma);
>> -    g_free(rdma_return_path);
>>   }
>>   
>>   void rdma_start_outgoing_migration(void *opaque,

Reviewed-by: Juan Quintela <quintela@redhat.com>

Regenerating it on my local tree and queuing.

Thanks,