[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 07/14] qapi: Fix error message when type name or array is exp
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH 07/14] qapi: Fix error message when type name or array is expected |
|
Date: |
Thu, 16 Mar 2023 19:57:18 -0500 |
|
User-agent: |
NeoMutt/20220429 |
On Thu, Mar 16, 2023 at 08:13:18AM +0100, Markus Armbruster wrote:
> We incorrectly report "FOO should be a type name" when it could also
> be an array. Fix that.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> scripts/qapi/expr.py | 15 +++++++--------
> tests/qapi-schema/event-nest-struct.err | 2 +-
> tests/qapi-schema/nested-struct-data.err | 2 +-
> tests/qapi-schema/returns-dict.err | 2 +-
> tests/qapi-schema/struct-member-invalid.err | 2 +-
> 5 files changed, 11 insertions(+), 12 deletions(-)
>
Doesn't change the set of schemas accepted, but does make it easier to
understand when a schema is rejected.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- [PATCH 14/14] qapi: Require boxed for conditional command and event arguments, (continued)
- [PATCH 14/14] qapi: Require boxed for conditional command and event arguments, Markus Armbruster, 2023/03/16
- [PATCH 04/14] qapi: Split up check_type(), Markus Armbruster, 2023/03/16
- [PATCH 03/14] qapi: Clean up after removal of simple unions, Markus Armbruster, 2023/03/16
- [PATCH 06/14] qapi: Simplify code a bit after previous commit, Markus Armbruster, 2023/03/16
- [PATCH 09/14] tests/qapi-schema: Improve union discriminator coverage, Markus Armbruster, 2023/03/16
- [PATCH 07/14] qapi: Fix error message when type name or array is expected, Markus Armbruster, 2023/03/16
- Re: [PATCH 07/14] qapi: Fix error message when type name or array is expected,
Eric Blake <=
- [PATCH 10/14] tests/qapi-schema: Rename a few conditionals, Markus Armbruster, 2023/03/16