[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/6] virtio-input-pci: add virtio-multitouch-pci
From: |
Marc-André Lureau |
Subject: |
Re: [PATCH v2 4/6] virtio-input-pci: add virtio-multitouch-pci |
Date: |
Fri, 17 Mar 2023 12:05:04 +0400 |
On Thu, Mar 16, 2023 at 4:07 PM Sergio Lopez <slp@redhat.com> wrote:
>
> Add virtio-multitouch-pci, a Multitouch-capable input device, to the
> list of devices that can be provided by virtio-input-pci.
>
> Signed-off-by: Sergio Lopez <slp@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> hw/virtio/virtio-input-pci.c | 25 +++++++++++++++++++++----
> 1 file changed, 21 insertions(+), 4 deletions(-)
>
> diff --git a/hw/virtio/virtio-input-pci.c b/hw/virtio/virtio-input-pci.c
> index a9d0992389..a53edf46c4 100644
> --- a/hw/virtio/virtio-input-pci.c
> +++ b/hw/virtio/virtio-input-pci.c
> @@ -25,10 +25,11 @@ struct VirtIOInputPCI {
> VirtIOInput vdev;
> };
>
> -#define TYPE_VIRTIO_INPUT_HID_PCI "virtio-input-hid-pci"
> -#define TYPE_VIRTIO_KEYBOARD_PCI "virtio-keyboard-pci"
> -#define TYPE_VIRTIO_MOUSE_PCI "virtio-mouse-pci"
> -#define TYPE_VIRTIO_TABLET_PCI "virtio-tablet-pci"
> +#define TYPE_VIRTIO_INPUT_HID_PCI "virtio-input-hid-pci"
> +#define TYPE_VIRTIO_KEYBOARD_PCI "virtio-keyboard-pci"
> +#define TYPE_VIRTIO_MOUSE_PCI "virtio-mouse-pci"
> +#define TYPE_VIRTIO_TABLET_PCI "virtio-tablet-pci"
> +#define TYPE_VIRTIO_MULTITOUCH_PCI "virtio-multitouch-pci"
> OBJECT_DECLARE_SIMPLE_TYPE(VirtIOInputHIDPCI, VIRTIO_INPUT_HID_PCI)
>
> struct VirtIOInputHIDPCI {
> @@ -102,6 +103,14 @@ static void virtio_tablet_initfn(Object *obj)
> TYPE_VIRTIO_TABLET);
> }
>
> +static void virtio_multitouch_initfn(Object *obj)
> +{
> + VirtIOInputHIDPCI *dev = VIRTIO_INPUT_HID_PCI(obj);
> +
> + virtio_instance_init_common(obj, &dev->vdev, sizeof(dev->vdev),
> + TYPE_VIRTIO_MULTITOUCH);
> +}
> +
> static const TypeInfo virtio_input_pci_info = {
> .name = TYPE_VIRTIO_INPUT_PCI,
> .parent = TYPE_VIRTIO_PCI,
> @@ -140,6 +149,13 @@ static const VirtioPCIDeviceTypeInfo
> virtio_tablet_pci_info = {
> .instance_init = virtio_tablet_initfn,
> };
>
> +static const VirtioPCIDeviceTypeInfo virtio_multitouch_pci_info = {
> + .generic_name = TYPE_VIRTIO_MULTITOUCH_PCI,
> + .parent = TYPE_VIRTIO_INPUT_HID_PCI,
> + .instance_size = sizeof(VirtIOInputHIDPCI),
> + .instance_init = virtio_multitouch_initfn,
> +};
> +
> static void virtio_pci_input_register(void)
> {
> /* Base types: */
> @@ -150,6 +166,7 @@ static void virtio_pci_input_register(void)
> virtio_pci_types_register(&virtio_keyboard_pci_info);
> virtio_pci_types_register(&virtio_mouse_pci_info);
> virtio_pci_types_register(&virtio_tablet_pci_info);
> + virtio_pci_types_register(&virtio_multitouch_pci_info);
> }
>
> type_init(virtio_pci_input_register)
> --
> 2.38.1
>
>
--
Marc-André Lureau
- [PATCH v2 0/6] Implement virtio-multitouch and enable GTK3 to use it, Sergio Lopez, 2023/03/16
- [PATCH v2 1/6] virtio-input: generalize virtio_input_key_config(), Sergio Lopez, 2023/03/16
- [PATCH v2 3/6] virtio-input: add a virtio-mulitouch device, Sergio Lopez, 2023/03/16
- [PATCH v2 2/6] ui: add the infrastructure to support MT events, Sergio Lopez, 2023/03/16
- [PATCH v2 4/6] virtio-input-pci: add virtio-multitouch-pci, Sergio Lopez, 2023/03/16
- Re: [PATCH v2 4/6] virtio-input-pci: add virtio-multitouch-pci,
Marc-André Lureau <=
- [PATCH v2 5/6] ui: add helpers for virtio-multitouch events, Sergio Lopez, 2023/03/16
- [PATCH v2 6/6] ui/gtk: enable backend to send multi-touch events, Sergio Lopez, 2023/03/16