Re: [PULL v2 08/18] ui: keep current cursor with QemuConsole

[Daniel P . Berrangé]

On Tue, Mar 14, 2023 at 12:01:24AM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Keeping the current cursor around is useful, not only for VNC, but for
> other displays. Let's move it down, see the following patches for other
> usages.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  include/ui/console.h | 1 +
>  ui/vnc.h             | 1 -
>  ui/console.c         | 8 ++++++++
>  ui/vnc.c             | 7 ++-----
>  4 files changed, 11 insertions(+), 6 deletions(-)

Unfortunately this commit appears to have casued a regresion leading
to a SEGV crash in VNC reported by a user:

  https://gitlab.com/qemu-project/qemu/-/issues/1548


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|