Re: [PATCH for 8.0] qemu/osdep: Switch position of "extern" and "G_NORETURN"

[Peter Maydell]

On Sat, 18 Mar 2023 at 19:00, Bernhard Beschow <shentey@gmail.com> wrote:
>
> Fixes the Windows build under msys2 using GCC 12 which fails with the 
> following
> error:


Apparently it also fixes the compilation with Clang 15 (see
https://gitlab.com/qemu-project/qemu/-/issues/1541 ).

You could use a Resolves: tag so the bug gets closed when
this is applied.

> diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
> index f68b5d8708..9eff0be95b 100644
> --- a/include/qemu/osdep.h
> +++ b/include/qemu/osdep.h
> @@ -237,7 +237,7 @@ extern "C" {
>   * supports QEMU_ERROR, this will be reported at compile time; otherwise
>   * this will be reported at link time due to the missing symbol.
>   */
> -extern G_NORETURN
> +G_NORETURN extern
>  void QEMU_ERROR("code path is reachable")
>      qemu_build_not_reached_always(void);
>  #if defined(__OPTIMIZE__) && !defined(__NO_INLINE__)
> --

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM