qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/9] linux-user: Diagnose misaligned -R size


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 1/9] linux-user: Diagnose misaligned -R size
Date: Mon, 20 Mar 2023 22:24:03 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0

On 17/3/23 16:54, Richard Henderson wrote:
We have been enforcing host page alignment for the non-R
fallback of MAX_RESERVED_VA, but failing to enforce for -R.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
  linux-user/main.c | 6 ++++++
  1 file changed, 6 insertions(+)

diff --git a/linux-user/main.c b/linux-user/main.c
index 4b18461969..39d9bd4d7a 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -793,6 +793,12 @@ int main(int argc, char **argv, char **envp)
       */
      max_reserved_va = MAX_RESERVED_VA(cpu);
      if (reserved_va != 0) {
+        if (reserved_va % qemu_host_page_size) {
+            char *s = size_to_str(qemu_host_page_size);
+            fprintf(stderr, "Reserved virtual address not aligned mod %s\n", 
s);
+            g_free(s);
+            exit(EXIT_FAILURE);
+        }
          if (max_reserved_va && reserved_va > max_reserved_va) {
              fprintf(stderr, "Reserved virtual address too big\n");
              exit(EXIT_FAILURE);

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]