[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] python: honour message limit when using pre-opened socket
From: |
John Snow |
Subject: |
Re: [PATCH] python: honour message limit when using pre-opened socket |
Date: |
Mon, 20 Mar 2023 20:27:58 -0400 |
On Mon, Mar 20, 2023 at 8:20 AM Vladimir Sementsov-Ogievskiy
<vsementsov@yandex-team.ru> wrote:
>
> On 20.03.23 13:54, Daniel P. Berrangé wrote:
> > The default message recv limit in asyncio is smaller than our needs, so
> > when opening connections we override it. This was done when opening a
> > connection using a socket address, but was missed when using a
> > pre-opened socket file descriptor.
> >
> > This latent bug was exposed when the QEMUMachine class was enhanced to
> > use socketpair() when no socket address was passed by:
> >
> > commit bd4c0ef409140bd1be393407c04005ac077d4574
> > Author: Marc-André Lureau<marcandre.lureau@redhat.com>
> > Date: Wed Jan 11 12:01:01 2023 +0400
> >
> > python/qemu/machine: use socketpair() for QMP by default
> >
> > Signed-off-by: Daniel P. Berrangé<berrange@redhat.com>
>
> Tested-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
>
> Thanks!
>
> --
> Best regards,
> Vladimir
>
Thanks x3. Will stage in both places.
--js