[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 2/2] Add test for storing .new vector
|
From: |
Marco Liebel |
|
Subject: |
RE: [PATCH 2/2] Add test for storing .new vector |
|
Date: |
Tue, 21 Mar 2023 18:20:22 +0000 |
> -----Original Message-----
> From: Peter Maydell <peter.maydell@linaro.org>
> Sent: Dienstag, 21. März 2023 18:20
> To: Marco Liebel (QUIC) <quic_mliebel@quicinc.com>
> Cc: qemu-devel@nongnu.org; Taylor Simpson <tsimpson@quicinc.com>;
> Matheus Bernardino (QUIC) <quic_mathbern@quicinc.com>
> Subject: Re: [PATCH 2/2] Add test for storing .new vector
>
> WARNING: This email originated from outside of Qualcomm. Please be wary
> of any links or attachments, and do not enable macros.
>
> On Tue, 21 Mar 2023 at 14:13, Marco Liebel <quic_mliebel@quicinc.com>
> wrote:
> >
> > Hexagon toolchain version 16.0.0 fixes a bug where the ecoding of
> > storing a .new vector was incorrect. This resulted in an incorrect
> > valued being stored. The test checks that the correct value is used.
>
> So is this a compiler/assembler bug? Do we need to have tests
> relating to those in QEMU's test suite ?
>
> thanks
> -- PMM
The bug was in the assembler. For the instruction that does the store of the
.new vector (vmem(r0+#0) = v3.new) it created the wrong output. So there
should be no need to have more tests, other than the one provided by this
patch.
Marco