Re: [PATCH 1/2] tests/vm: skip X11 in openbsd installation

[Philippe Mathieu-Daudé]

On 22/3/23 14:40, Thomas Huth wrote:
> On 22/03/2023 14.38, Philippe Mathieu-Daudé wrote:
> > On 22/3/23 13:36, Daniel P. Berrangé wrote:
> > > As a VM used only for automated testing there is no need to
> > > install the X11 stack.
> > >
> > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > > ---
> > >   tests/vm/openbsd | 3 +--
> > >   1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/tests/vm/openbsd b/tests/vm/openbsd
> > > index eaeb201e91..6af7afac0d 100755
> > > --- a/tests/vm/openbsd
> > > +++ b/tests/vm/openbsd
> > > @@ -106,8 +106,7 @@ class OpenBSDVM(basevm.BaseVM):
> > >           self.console_wait("Password for root account")
> > >           self.console_send("%s\n" % self._config["root_pass"])
> > >           self.console_wait_send("Start sshd(8)",           "yes\n")
> > > -        self.console_wait_send("X Window System",         "\n")
> > > -        self.console_wait_send("xenodm",                  "\n")
> > > +        self.console_wait_send("X Window System",         "no\n")
> >
> > Wasn't this useful to link a X11-ready binary, even if only testing
> > with -display=none?
>
> tests/vm/openbsd later installs sdl2 and gtk+3, so I assume that will 
> pull in the required libraries if necessary, without all the other 
> non-necessary stuff.

Good then, thanks for checking!

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>