qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH RESEND v2] hw/i2c: Enable an id for the pca954x devices


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH RESEND v2] hw/i2c: Enable an id for the pca954x devices
Date: Wed, 22 Mar 2023 22:40:34 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0

On 22/3/23 22:19, Corey Minyard wrote:
On Wed, Mar 22, 2023 at 10:21:36AM -0700, Patrick Venture wrote:
This allows the devices to be more readily found and specified.
Without setting the name field, they can only be found by device type
name, which doesn't let you specify the second of the same device type
behind a bus.

Tested: Verified that by default the device was findable with the name
'pca954x[77]', for an instance attached at that address.

This looks good to me.

Acked-by: Corey Minyard <cminyard@mvista.com>

if you are taking this in through another tree.  Or do you want me to
take this?

Since I have to send a MIPS PR, I'll take this one;
to alleviate you and the CI minutes.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]