[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 2/3] qga: Add `merged` variant to GuestExecCaptureOutputMo
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v6 2/3] qga: Add `merged` variant to GuestExecCaptureOutputMode |
Date: |
Thu, 23 Mar 2023 09:26:24 +0000 |
User-agent: |
Mutt/2.2.9 (2022-11-12) |
On Wed, Mar 22, 2023 at 06:19:27PM -0600, Daniel Xu wrote:
> Currently, any captured output (via `capture-output`) is segregated into
> separate GuestExecStatus fields (`out-data` and `err-data`). This means
> that downstream consumers have no way to reassemble the captured data
> back into the original stream.
>
> This is relevant for chatty and semi-interactive (ie. read only) CLI
> tools. Such tools may deliberately interleave stdout and stderr for
> visual effect. If segregated, the output becomes harder to visually
> understand.
>
> This commit adds a new enum variant to the GuestExecCaptureOutputMode
> qapi to merge the output streams such that consumers can have a pristine
> view of the original command output.
>
> Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
> ---
> qga/commands.c | 25 +++++++++++++++++++++++--
> qga/qapi-schema.json | 5 ++++-
> 2 files changed, 27 insertions(+), 3 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|