[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 1/1] util/async-teardown: wire up query-command-line-optio
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v5 1/1] util/async-teardown: wire up query-command-line-options |
Date: |
Tue, 28 Mar 2023 07:26:55 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Paolo Bonzini <pbonzini@redhat.com> writes:
> I am honestly not a fan of adding a more complex option,.just because
> query-command-line-options only returns the square holes whereas here we
> got a round one.
>
> Can we imagine another functionality that would be added to -teardown? If
> not, it's not a good design. If it works, I would add a completely dummy
> (no suboptions) group "async-teardown" and not modify the parsing at all.
Does v2 implement your suggestion?
Message-Id: <20230320131648.61728-1-imbrenda@linux.ibm.com>
I dislike it, because it makes query-command-line-options claim
-async-teardown has an option argument with unknown keys, which is
plainly wrong, and must be treated as a special case. Worse, a new kind
of special case.
Can we have a QMP command, so libvirt can use query-qmp-schema?
In case QMP becomes functional too late for the command to actually
work: make it always fail for now. It can still serve as a witness for
-async-teardown. If we rework QEMU startup so that QMP can do
everything the CLI can do, we'll make the QMP command work.