Re: egl compile error on msys CI runners

[Daniel P . Berrangé]

On Wed, Mar 29, 2023 at 11:01:35AM +0400, Marc-André Lureau wrote:
> Hi Peter
> 
> On Tue, Mar 28, 2023 at 6:39 PM Peter Maydell <peter.maydell@linaro.org> 
> wrote:
> >
> > The msys CI runners have started failing to compile with an EGL
> > related error:
> >
> > https://gitlab.com/qemu-project/qemu/-/jobs/4015682307
> >
> > In file included from
> > C:/GitLab-Runner/builds/qemu-project/qemu/msys64/mingw64/include/epoxy/egl.h:46,
> > from C:/GitLab-Runner/builds/qemu-project/qemu/include/ui/egl-helpers.h:5,
> > from ../ui/egl-helpers.c:21:
> > C:/GitLab-Runner/builds/qemu-project/qemu/msys64/mingw64/include/epoxy/egl_generated.h:11:10:
> > fatal error: EGL/eglplatform.h: No such file or directory
> > 11 | #include "EGL/eglplatform.h"
> > | ^~~~~~~~~~~~~~~~~~~
> > ninja: build stopped: subcommand failed.
> >
> > Dan says this is because of a msys2 packaging issue:
> > https://github.com/msys2/MINGW-packages/issues/16492
> >
> > Can we have a meson test that doesn't try to enable EGL on systems
> > like this one where it's broken ? Changing the current meson.build
> >   if cc.has_header('epoxy/egl.h', dependencies: epoxy)
> > to whatever the meson is for "actually try to compile with the
> > header" ought to do the trick, I think.
> >
> 
> This is an unfortunate consequence of using a fast-moving rolling
> distribution, there are random breakages. It would make sense to have
> tagged / pre-built images instead. That would also speed up the CI a
> bit, hopefully.

IMHO if the distro is considered susceptible to ongoing random
breakage we must not use it as a gating CI job. IOW, these
msys jobs should have 'allow-failure: true' added to their
definition.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|