Re: [PATCH] lasi: fix RTC

[Peter Maydell]

On Thu, 30 Mar 2023 at 13:03, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> Migrate rtc_ref (which only needs to be 32-bit because it is summed to
> a 32-bit register) and drop the write-only field rtc from LasiState.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  hw/misc/lasi.c         | 2 +-
>  include/hw/misc/lasi.h | 3 +--
>  2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/hw/misc/lasi.c b/hw/misc/lasi.c
> index 23a7634a8c3a..5d07bc801a84 100644
> --- a/hw/misc/lasi.c
> +++ b/hw/misc/lasi.c
> @@ -204,6 +204,7 @@ static const VMStateDescription vmstate_lasi = {
>          VMSTATE_UINT32(iar, LasiState),
>          VMSTATE_UINT32(errlog, LasiState),
>          VMSTATE_UINT32(amr, LasiState),
> +        VMSTATE_UINT32(rtc_ref, LasiState),
>          VMSTATE_END_OF_LIST()
>      }

This is a migration compat break -- the commit message should
explain why this is OK to do (and the version number should
probably be bumped too).

>  };

thanks
-- PMM