[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 07/16] hw/i3c/aspeed_i3c: Use 32 bits on MMIO writes
From: |
Joe Komlodi |
Subject: |
[PATCH 07/16] hw/i3c/aspeed_i3c: Use 32 bits on MMIO writes |
Date: |
Fri, 31 Mar 2023 01:01:22 +0000 |
The registers are only 32 bits wide, so we should cast the 64-bit value
passed in to only be 32 bits wide.
Signed-off-by: Joe Komlodi <komlodi@google.com>
Reviewed-by: Patrick Venture <venture@google.com>
Reviewed-by: Titus Rwantare <titusr@google.com>
---
hw/i3c/aspeed_i3c.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/i3c/aspeed_i3c.c b/hw/i3c/aspeed_i3c.c
index 79715f462d..2ed09234ff 100644
--- a/hw/i3c/aspeed_i3c.c
+++ b/hw/i3c/aspeed_i3c.c
@@ -441,10 +441,11 @@ static void aspeed_i3c_device_write(void *opaque, hwaddr
offset,
{
AspeedI3CDevice *s = ASPEED_I3C_DEVICE(opaque);
uint32_t addr = offset >> 2;
+ uint32_t val32 = (uint32_t)value;
trace_aspeed_i3c_device_write(s->id, offset, value);
- value &= ~ast2600_i3c_device_ro[addr];
+ val32 &= ~ast2600_i3c_device_ro[addr];
switch (addr) {
case R_HW_CAPABILITY:
case R_RESPONSE_QUEUE_PORT:
@@ -470,7 +471,7 @@ static void aspeed_i3c_device_write(void *opaque, hwaddr
offset,
case R_RESET_CTRL:
break;
default:
- s->regs[addr] = value;
+ s->regs[addr] = val32;
break;
}
}
--
2.40.0.348.gf938b09366-goog
- [PATCH 00/16] i3c: aspeed: Add I3C support, Joe Komlodi, 2023/03/30
- [PATCH 01/16] hw/misc/aspeed_i3c: Move to i3c directory, Joe Komlodi, 2023/03/30
- [PATCH 03/16] hw/i3c/aspeed_i3c: Add more register fields, Joe Komlodi, 2023/03/30
- [PATCH 04/16] hw/i3c/aspeed_i3c: Add more reset values, Joe Komlodi, 2023/03/30
- [PATCH 02/16] hw/i3c: Add bus support, Joe Komlodi, 2023/03/30
- [PATCH 05/16] hw/i3c/aspeed_i3c: Add register RO field masks, Joe Komlodi, 2023/03/30
- [PATCH 06/16] hw/i3c/aspeed_i3c: Treat more registers as read-as-zero, Joe Komlodi, 2023/03/30
- [PATCH 07/16] hw/i3c/aspeed_i3c: Use 32 bits on MMIO writes,
Joe Komlodi <=
- [PATCH 08/16] hw/i3c/aspeed_i3c: Add IRQ MMIO behavior, Joe Komlodi, 2023/03/30
- [PATCH 09/16] hw/i3c/aspeed_i3c: Add data TX and RX, Joe Komlodi, 2023/03/30
- [PATCH 10/16] hw/i3c/aspeed_i3c: Add IBI handling, Joe Komlodi, 2023/03/30
- [PATCH 11/16] hw/i3c/aspeed_i3c: Add ctrl MMIO handling, Joe Komlodi, 2023/03/30
- [PATCH 12/16] hw/i3c/aspeed_i3c: Add controller resets, Joe Komlodi, 2023/03/30
- [PATCH 13/16] hw/i3c: Add Mock target, Joe Komlodi, 2023/03/30
- [PATCH 14/16] hw/i3c: remote_i3c: Add model, Joe Komlodi, 2023/03/30
- [PATCH 16/16] hw/i3c: Add hotplug support, Joe Komlodi, 2023/03/30
- [PATCH 15/16] qtest: remote_i3c: Add remote I3C qtest, Joe Komlodi, 2023/03/30