[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/4] migration/qapi: Drop @MigrationParameter enum
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH v2 4/4] migration/qapi: Drop @MigrationParameter enum |
|
Date: |
Tue, 29 Aug 2023 12:51:19 +0100 |
|
User-agent: |
Mutt/2.2.9 (2022-11-12) |
On Fri, Aug 25, 2023 at 01:15:17PM -0400, Peter Xu wrote:
> Drop the enum in qapi because it is never used in QMP APIs. Instead making
> it an internal definition for QEMU so that we can decouple it from QAPI,
> and also we can deduplicate the QAPI documentations.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> qapi/migration.json | 179 ---------------------------------
> migration/options.h | 47 +++++++++
> migration/migration-hmp-cmds.c | 3 +-
> migration/options.c | 51 ++++++++++
> 4 files changed, 100 insertions(+), 180 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|