qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH V5 1/5] util: str_split


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH V5 1/5] util: str_split
Date: Mon, 26 Feb 2024 13:21:02 +0100
User-agent: Mozilla Thunderbird

On 22/2/24 22:47, Steve Sistare wrote:
Generalize hmp_split_at_comma() to take any delimiter string, rename
as str_split(), and move it to util/strList.c.

No functional change.

Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
---
  include/monitor/hmp.h  |  1 -
  include/qemu/strList.h | 24 ++++++++++++++++++++++++
  monitor/hmp-cmds.c     | 19 -------------------
  net/net-hmp-cmds.c     |  3 ++-
  stats/stats-hmp-cmds.c |  3 ++-
  util/meson.build       |  1 +
  util/strList.c         | 24 ++++++++++++++++++++++++
  7 files changed, 53 insertions(+), 22 deletions(-)

  create mode 100644 include/qemu/strList.h
  create mode 100644 util/strList.c

Markus, is that OK to include these two in your QAPI
section in MAINTAINERS? Squashing:

-- >8 --
diff --git a/MAINTAINERS b/MAINTAINERS
index 992799171f..7970d34cdd 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3196,6 +3196,8 @@ X: qapi/*.json
 F: include/qapi/
 X: include/qapi/qmp/
 F: include/qapi/qmp/dispatch.h
+F: include/qemu/strList.h
+F: util/strList.c
 F: tests/qapi-schema/
 F: tests/unit/test-*-visitor.c
 F: tests/unit/test-qapi-*.c
---



reply via email to

[Prev in Thread] Current Thread [Next in Thread]