[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 15/17] gdbstub: assert earlier in handle_read_all_regs
From: |
Alex Bennée |
Subject: |
[PATCH v4 15/17] gdbstub: assert earlier in handle_read_all_regs |
Date: |
Tue, 3 Jun 2025 12:02:02 +0100 |
When things go wrong we want to assert on the register that failed to
be able to figure out what went wrong.
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
gdbstub/gdbstub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c
index 565f6b33a9..6023c80d25 100644
--- a/gdbstub/gdbstub.c
+++ b/gdbstub/gdbstub.c
@@ -1343,8 +1343,8 @@ static void handle_read_all_regs(GArray *params, void
*user_ctx)
len += gdb_read_register(gdbserver_state.g_cpu,
gdbserver_state.mem_buf,
reg_id);
+ g_assert(len == gdbserver_state.mem_buf->len);
}
- g_assert(len == gdbserver_state.mem_buf->len);
gdb_memtohex(gdbserver_state.str_buf, gdbserver_state.mem_buf->data, len);
gdb_put_strbuf();
--
2.47.2
- Re: [PATCH v4 09/17] hw/display: re-arrange memory region tracking, (continued)
- Re: [PATCH v4 09/17] hw/display: re-arrange memory region tracking, Alex Bennée, 2025/06/05
- Re: [PATCH v4 09/17] hw/display: re-arrange memory region tracking, Akihiko Odaki, 2025/06/06
- Re: [PATCH v4 09/17] hw/display: re-arrange memory region tracking, Alex Bennée, 2025/06/06
- Re: [PATCH v4 09/17] hw/display: re-arrange memory region tracking, Akihiko Odaki, 2025/06/06
- Re: [PATCH v4 09/17] hw/display: re-arrange memory region tracking, Akihiko Odaki, 2025/06/08
[PATCH v4 11/17] ui/gtk-gl-area: Remove extra draw call in refresh, Alex Bennée, 2025/06/03
[PATCH v4 12/17] virtio-gpu: support context init multiple timeline, Alex Bennée, 2025/06/03
[PATCH v4 08/17] MAINTAINERS: add Akihiko and Dmitry as reviewers, Alex Bennée, 2025/06/03
[PATCH v4 13/17] include/exec: fix assert in size_memop, Alex Bennée, 2025/06/03
[PATCH v4 15/17] gdbstub: assert earlier in handle_read_all_regs,
Alex Bennée <=
[PATCH v4 10/17] virtio-gpu: refactor async blob unmapping, Alex Bennée, 2025/06/03
[PATCH v4 17/17] gdbstub: update aarch64-core.xml, Alex Bennée, 2025/06/03
[PATCH v4 16/17] gdbstub: Implement qGDBServerVersion packet, Alex Bennée, 2025/06/03
[PATCH v4 14/17] include/gdbstub: fix include guard in commands.h, Alex Bennée, 2025/06/03