[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 09/12] hw/riscv/virt: Use setprop_sized_cells for uart
From: |
Joel Stanley |
Subject: |
[PATCH v2 09/12] hw/riscv/virt: Use setprop_sized_cells for uart |
Date: |
Wed, 4 Jun 2025 12:24:45 +0930 |
The current device tree property uses two cells for the address (and for
the size), but assumes the they are less than 32 bits by hard coding the
high cell to zero.
Use qemu_fdt_setprop_sized_cells to do the job of splitting the upper
and lower 32 bits across cells.
Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
hw/riscv/virt.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
index b59f10dabe19..7c38a9048044 100644
--- a/hw/riscv/virt.c
+++ b/hw/riscv/virt.c
@@ -966,9 +966,9 @@ static void create_fdt_uart(RISCVVirtState *s,
s->memmap[VIRT_UART0].base);
qemu_fdt_add_subnode(ms->fdt, name);
qemu_fdt_setprop_string(ms->fdt, name, "compatible", "ns16550a");
- qemu_fdt_setprop_cells(ms->fdt, name, "reg",
- 0x0, s->memmap[VIRT_UART0].base,
- 0x0, s->memmap[VIRT_UART0].size);
+ qemu_fdt_setprop_sized_cells(ms->fdt, name, "reg",
+ 2, s->memmap[VIRT_UART0].base,
+ 2, s->memmap[VIRT_UART0].size);
qemu_fdt_setprop_cell(ms->fdt, name, "clock-frequency", 3686400);
qemu_fdt_setprop_cell(ms->fdt, name, "interrupt-parent", irq_mmio_phandle);
if (s->aia_type == VIRT_AIA_TYPE_NONE) {
--
2.47.2
- [PATCH v2 00/12] hw/riscv/virt: device tree reg cleanups, Joel Stanley, 2025/06/03
- [PATCH v2 01/12] hw/riscv/virt: Fix clint base address type, Joel Stanley, 2025/06/03
- [PATCH v2 02/12] hw/riscv/virt: Use setprop_sized_cells for clint, Joel Stanley, 2025/06/03
- [PATCH v2 03/12] hw/riscv/virt: Use setprop_sized_cells for memory, Joel Stanley, 2025/06/03
- [PATCH v2 04/12] hw/riscv/virt: Use setprop_sized_cells for aplic, Joel Stanley, 2025/06/03
- [PATCH v2 05/12] hw/riscv/virt: Use setprop_sized_cells for aclint, Joel Stanley, 2025/06/03
- [PATCH v2 06/12] hw/riscv/virt: Use setprop_sized_cells for plic, Joel Stanley, 2025/06/03
- [PATCH v2 07/12] hw/riscv/virt: Use setprop_sized_cells for virtio, Joel Stanley, 2025/06/03
- [PATCH v2 08/12] hw/riscv/virt: Use setprop_sized_cells for reset, Joel Stanley, 2025/06/03
- [PATCH v2 09/12] hw/riscv/virt: Use setprop_sized_cells for uart,
Joel Stanley <=
- [PATCH v2 10/12] hw/riscv/virt: Use setprop_sized_cells for rtc, Joel Stanley, 2025/06/03
- [PATCH v2 11/12] hw/riscv/virt: Use setprop_sized_cells for iommu, Joel Stanley, 2025/06/03
- [PATCH v2 12/12] hw/riscv/virt: Use setprop_sized_cells for pcie, Joel Stanley, 2025/06/03
- Re: [PATCH v2 00/12] hw/riscv/virt: device tree reg cleanups, Alistair Francis, 2025/06/12