Re: [RFC PATCH v12 2/4] hw/vfio/ap: store object indicating AP config changed in a queue

[Rorie Reyes]

On 6/9/25 6:19 AM, Anthony Krowiak wrote:

> > +   
> >         QTAILQ_INSERT_TAIL(&cfg_chg_events, cfg_chg_event, next);
> >         
> >       
>       
>       Need locking here:
>       
>       
>       WITH_QEMU_LOCK_GUARD(&cfg_chg_events_lock) {
>       
>       
>       QTAILQ_INSERT_TAIL(&cfg_chg_events, cfg_chg_event, next);
>       
>       
>       }
    Wouldn't QEMU_LOCK_GUARD(&cfg_chg_events_lock) be better since
    it's a one line? Or the fact there's no return here makes it
    insufficient?