Re: [PATCH v3 06/23] vfio-user: add vfio-user class and container

[John Levon]

On Thu, Jun 12, 2025 at 08:39:17AM +0200, Cédric Le Goater wrote:

> > +static void vfio_user_pci_realize(PCIDevice *pdev, Error **errp)
> > +{
> > +    ERRP_GUARD();
> > +    VFIOUserPCIDevice *udev = VFIO_USER_PCI(pdev);
> > +    VFIOPCIDevice *vdev = VFIO_PCI_BASE(pdev);
> > +    VFIODevice *vbasedev = &vdev->vbasedev;
> > +    AddressSpace *as;
> > +
> > +    /*
> > +     * TODO: make option parser understand SocketAddress
> > +     * and use that instead of having scalar options
> > +     * for each socket type.
> 
> Please take a look at vfu_object_class_init() to handle the
> "socket" property.

Thanks for the pointer: done. I had to switch to using JSON-style device
specification for this though, so updated docs too.

regards
john