[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] i386/tdx: handle TDG.VP.VMCALL<GetQuote>
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH 3/3] i386/tdx: handle TDG.VP.VMCALL<GetQuote> |
|
Date: |
Fri, 20 Jun 2025 09:47:09 +0200 |
On Fri, Jun 20, 2025 at 8:47 AM Xiaoyao Li <xiaoyao.li@intel.com> wrote:
> > +void tdx_handle_get_quote(X86CPU *cpu, struct kvm_run *run)
>
> The previous version of mine, defined the return type as int, because it
> wants to stop the QEMU when it hits the failure of
> address_space_read/write. However, this patch returns
> TDG_VP_VMCALL_INVALID_OPERAND to TD guest for such cases.
>
> Shouldn't the failure of address_space_read/write be treated as QEMU
> internal error?
The operands are provided by the guest, therefore I think it's an
invalid operand error.
Paolo