[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH] PPC: Only enter MSR_POW when no interrupts pendin
From: |
Tom Musta |
Subject: |
Re: [Qemu-ppc] [PATCH] PPC: Only enter MSR_POW when no interrupts pending |
Date: |
Mon, 07 Apr 2014 12:28:12 -0500 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 4/6/2014 3:55 PM, Alexander Graf wrote:
> We were entering the power saving state even when interrupts (like an
> external interrupt or a decrementer interrupt) were still in flight.
>
> In case we find a pending interrupt, don't enter power saving state.
>
> Signed-off-by: Alexander Graf <address@hidden>
> ---
> target-ppc/helper_regs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-ppc/helper_regs.h b/target-ppc/helper_regs.h
> index f7ec9c2..271fddf 100644
> --- a/target-ppc/helper_regs.h
> +++ b/target-ppc/helper_regs.h
> @@ -101,7 +101,7 @@ static inline int hreg_store_msr(CPUPPCState *env,
> target_ulong value,
> hreg_compute_hflags(env);
> #if !defined(CONFIG_USER_ONLY)
> if (unlikely(msr_pow == 1)) {
> - if ((*env->check_pow)(env)) {
> + if (!env->pending_interrupts && (*env->check_pow)(env)) {
> cs->halted = 1;
> excp = EXCP_HALTED;
> }
>
Reviewed-by: Tom Musta <address@hidden>