[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [for-2.7 PATCH v3 04/15] cpu: Add a sync version of cpu_r
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-ppc] [for-2.7 PATCH v3 04/15] cpu: Add a sync version of cpu_remove() |
Date: |
Thu, 26 May 2016 12:22:17 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 |
On 12/05/2016 05:48, Bharata B Rao wrote:
> This sync API will be used by the CPU hotplug code to wait for the CPU to
> completely get removed before flagging the failure to the device_add
> command.
>
> Sync version of this call is needed to correctly recover from CPU
> realization failures when ->plug() handler fails.
>
> Signed-off-by: Bharata B Rao <address@hidden>
> Reviewed-by: David Gibson <address@hidden>
> ---
> cpus.c | 12 ++++++++++++
> include/qom/cpu.h | 8 ++++++++
> 2 files changed, 20 insertions(+)
>
> diff --git a/cpus.c b/cpus.c
> index 3e7eada..0a6ae44 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -1082,6 +1082,8 @@ static void *qemu_kvm_cpu_thread_fn(void *arg)
> } while (!cpu->unplug || cpu_can_run(cpu));
>
> qemu_kvm_destroy_vcpu(cpu);
> + cpu->created = false;
> + qemu_cond_signal(&qemu_cpu_cond);
> qemu_mutex_unlock_iothread();
> return NULL;
> }
> @@ -1182,6 +1184,8 @@ static void *qemu_tcg_cpu_thread_fn(void *arg)
> }
> if (remove_cpu) {
> qemu_tcg_destroy_vcpu(remove_cpu);
> + cpu->created = false;
> + qemu_cond_signal(&qemu_cpu_cond);
> remove_cpu = NULL;
> }
> }
> @@ -1347,6 +1351,14 @@ void cpu_remove(CPUState *cpu)
> qemu_cpu_kick(cpu);
> }
>
> +void cpu_remove_sync(CPUState *cpu)
> +{
> + cpu_remove(cpu);
> + while (cpu->created) {
> + qemu_cond_wait(&qemu_cpu_cond, &qemu_global_mutex);
> + }
> +}
> +
> /* For temporary buffers for forming a name */
> #define VCPU_THREAD_NAME_SIZE 16
>
> diff --git a/include/qom/cpu.h b/include/qom/cpu.h
> index 911bc9f..9c544f6 100644
> --- a/include/qom/cpu.h
> +++ b/include/qom/cpu.h
> @@ -763,6 +763,14 @@ void cpu_resume(CPUState *cpu);
> */
> void cpu_remove(CPUState *cpu);
>
> + /**
> + * cpu_remove_sync:
> + * @cpu: The CPU to remove.
> + *
> + * Requests the CPU to be removed and waits till it is removed.
> + */
> +void cpu_remove_sync(CPUState *cpu);
> +
> /**
> * qemu_init_vcpu:
> * @cpu: The vCPU to initialize.
>
Acked-by: Paolo Bonzini <address@hidden>
- [Qemu-ppc] [for-2.7 PATCH v3 00/15] Core based CPU hotplug for PowerPC sPAPR, Bharata B Rao, 2016/05/11
- [Qemu-ppc] [for-2.7 PATCH v3 08/15] spapr: convert boot CPUs into CPU core devices, Bharata B Rao, 2016/05/11
- [Qemu-ppc] [for-2.7 PATCH v3 04/15] cpu: Add a sync version of cpu_remove(), Bharata B Rao, 2016/05/11
- Re: [Qemu-ppc] [for-2.7 PATCH v3 04/15] cpu: Add a sync version of cpu_remove(),
Paolo Bonzini <=
- [Qemu-ppc] [for-2.7 PATCH v3 05/15] qdev: hotplug: Introduce HotplugHandler.pre_plug() callback, Bharata B Rao, 2016/05/11
- [Qemu-ppc] [for-2.7 PATCH v3 11/15] spapr_drc: Prevent detach racing against attach for CPU DR, Bharata B Rao, 2016/05/11
- [Qemu-ppc] [for-2.7 PATCH v3 01/15] exec: Remove cpu from cpus list during cpu_exec_exit(), Bharata B Rao, 2016/05/11
[Qemu-ppc] [for-2.7 PATCH v3 02/15] exec: Do vmstate unregistration from cpu_exec_exit(), Bharata B Rao, 2016/05/11
[Qemu-ppc] [for-2.7 PATCH v3 13/15] QMP: Add query-hotpluggable-cpus, Bharata B Rao, 2016/05/11
[Qemu-ppc] [for-2.7 PATCH v3 12/15] spapr: CPU hot unplug support, Bharata B Rao, 2016/05/11