[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH] ppc: abort if compat property contains an unknown val
From: |
Greg Kurz |
Subject: |
[Qemu-ppc] [PATCH] ppc: abort if compat property contains an unknown value |
Date: |
Wed, 13 Jul 2016 12:00:17 +0200 |
User-agent: |
StGit/0.17.1-dirty |
It is not possible to set the compat property to an unknown value with
powerpc_set_compat(). Something must have gone terribly wrong in QEMU,
if we detect an "Internal error" in powerpc_get_compat(). Let's abort then.
This patch also drops the "max_compat ? *max_compat : -1" construct. It is
useless since max_compat is dereferenced a few lines above.
Signed-off-by: Greg Kurz <address@hidden>
---
target-ppc/translate_init.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index 55688db9c9db..79c86c477878 100644
--- a/target-ppc/translate_init.c
+++ b/target-ppc/translate_init.c
@@ -8446,8 +8446,8 @@ static void powerpc_get_compat(Object *obj, Visitor *v,
const char *name,
case 0:
break;
default:
- error_setg(errp, "Internal error: compat is set to %x",
- max_compat ? *max_compat : -1);
+ error_report("Internal error: compat is set to %x", *max_compat);
+ abort();
break;
}
- [Qemu-ppc] [PATCH] ppc: abort if compat property contains an unknown value,
Greg Kurz <=