[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCHv5 0/4] Clean up compatibility mode handling
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCHv5 0/4] Clean up compatibility mode handling |
Date: |
Tue, 13 Jun 2017 16:09:45 +0800 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Tue, Jun 13, 2017 at 03:01:40PM +0800, Andrea Bolognani wrote:
> On Fri, 2017-06-02 at 13:15 +1000, David Gibson wrote:
> > This is a rebased and revised version of my patches revising CPU
> > compatiblity mode handling on ppc, last posted in November. Since
> > then, many of the patches have already been merged (some for 2.9, some
> > since). This is what's left.
>
> As discussed yesterday on libvir-list, the current
> implementation will abort() when the user attempts to use
> a compat mode that's not valid for the host CPU, eg. on
> a POWER8 host:
>
> $ qemu-system-ppc64 \
> -nodefaults \
> -M pseries,accel=kvm \
> -cpu host,compat=power9
> Unexpected error in ppc_set_compat() at target/ppc/compat.c:135:
> qemu-system-ppc64: Compatibility PVR 0x0f000005 not valid for CPU
> Aborted
>
> We should probably report the error to the user in a slightly
> less destructive fashion :)
Good point. As I suspected, this was just an &error_abort somewhere I
should have used an &error_fatal. Fixed in the ppc-for-2.10 I just
pushed.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- Re: [Qemu-ppc] [PATCHv5 2/4] pseries: Move CPU compatibility property to machine, (continued)