[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [RFC for-2.12 1/8] spapr: Rename machine init functions f
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [RFC for-2.12 1/8] spapr: Rename machine init functions for clarity |
Date: |
Mon, 11 Dec 2017 20:39:30 +1100 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Mon, Dec 11, 2017 at 09:42:53AM +0100, Greg Kurz wrote:
> On Mon, 11 Dec 2017 18:08:01 +1100
> David Gibson <address@hidden> wrote:
>
> > Machine objects have two init functions - the generic QOM level
> > instance_init which should only do static object initialization, and
> > the Machine specific MachineClass::init which does the actual
> > construction of the machine.
> >
> > In spapr the functions implementing these two have names -
> > ppc_machine_initfn() and ppc_spapr_init() - which don't correspond closely
> > to either of those. To prevent people (read, me) from confusing which is
> > which, rename them spapr_instance_init() and spapr_machine_init() to
> > make it clearer which is which.
> >
> > While we're there rename ppc_spapr_reset() to spapr_machine_reset() to
> > match.
> >
> > Signed-off-by: David Gibson <address@hidden>
> > ---
>
> Reviewed-by: Greg Kurz <address@hidden>
Thanks. I'll merge this one into ppc-for-2.12 already, since it's
simple and not really related to the rest of this series.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- Re: [Qemu-ppc] [RFC for-2.12 2/8] spapr: Capabilities infrastructure, (continued)
[Qemu-ppc] [RFC for-2.12 1/8] spapr: Rename machine init functions for clarity, David Gibson, 2017/12/11
[Qemu-ppc] [RFC for-2.12 5/8] spapr: Assume msi_nonbroken, David Gibson, 2017/12/11
[Qemu-ppc] [RFC for-2.12 7/8] spapr: Handle VMX/VSX presence as an spapr capability flag, David Gibson, 2017/12/11
[Qemu-ppc] [RFC for-2.12 6/8] target/ppc: Clean up probing of VMX, VSX and DFP availability on KVM, David Gibson, 2017/12/11