[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 3/3] target/ppc: convert to TranslatorOps
From: |
Richard Henderson |
Subject: |
Re: [Qemu-ppc] [PATCH 3/3] target/ppc: convert to TranslatorOps |
Date: |
Thu, 15 Feb 2018 07:20:14 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 02/14/2018 07:14 PM, Emilio G. Cota wrote:
> A few changes worth noting:
>
> - Didn't migrate ctx->exception to DISAS_* since the exception field is
> in many cases architecturally relevant.
>
> - Moved the cross-page check from the end of translate_insn to tb_start.
>
> - Removed the exit(1) after a TCG temp leak; changed the fprintf there to
> qemu_log.
>
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
> target/ppc/translate.c | 329
> +++++++++++++++++++++++++------------------------
> 1 file changed, 167 insertions(+), 162 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~