[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v2 4/6] Categorize devices: i82374
From: |
Thomas Huth |
Subject: |
Re: [Qemu-ppc] [PATCH v2 4/6] Categorize devices: i82374 |
Date: |
Thu, 28 Mar 2019 08:04:02 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 |
On 27/03/2019 14.34, Ernest Esene wrote:
> Set category and describe the i82374 device
>
> Signed-off-by: Ernest Esene <address@hidden>
>
> ---
> v2:
> * split into separate patches
> ---
> hw/dma/i82374.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/dma/i82374.c b/hw/dma/i82374.c
> index 892f655a7e..5b42dd1bd4 100644
> --- a/hw/dma/i82374.c
> +++ b/hw/dma/i82374.c
> @@ -147,6 +147,8 @@ static void i82374_class_init(ObjectClass *klass, void
> *data)
> dc->realize = i82374_realize;
> dc->vmsd = &vmstate_i82374;
> dc->props = i82374_properties;
> + dc->desc = "Intel Enhanced DMA controller";
> + set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
> }
Not sure if CATEGORY_BRIDGE is really the right thing for a dma
controller ... maybe better put it into CATEGORY_MISC ?
Thomas
PS: By the way, does somebody know whether this device should be
user_creatable at all? ... what is the use-case for exposing a DMA
controller to the user?