Re: [PULL 00/45] ppc-for-5.0 queue 20200317

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL 00/45] ppc-for-5.0 queue 20200317
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
1689eda pseries: Update SLOF firmware image
72735a9 ppc/spapr: Ignore common "ibm,nmi-interlock" Linux bug
47df6f1 ppc/spapr: Implement FWNMI System Reset delivery
f1fef1f target/ppc: allow ppc_cpu_do_system_reset to take an alternate vector
3bd2159 ppc/spapr: Allow FWNMI on TCG
91debae ppc/spapr: Fix FWNMI machine check interrupt delivery
c9df752 ppc/spapr: Add FWNMI System Reset state
bed131f ppc/spapr: Change FWNMI names
b4a37dd ppc/spapr: Fix FWNMI machine check failure handling
6a32b19 spapr: Rename DT functions to newer naming convention
4e79406 spapr: Move creation of ibm,architecture-vec-5 property
21a3ae2 spapr: Move creation of ibm, dynamic-reconfiguration-memory dt node
bf5265e spapr/rtas: Reserve space for RTAS blob and log
446dace pseries: Update SLOF firmware image
f5bb445 ppc/spapr: Move GPRs setup to one place
b824828 target/ppc: Fix rlwinm on ppc64
0e75479 spapr/xive: use SPAPR_IRQ_IPI to define IPI ranges exposed to the guest
397ec17 hw/scsi/spapr_vscsi: Convert debug fprintf() to trace event
e8ff332 hw/scsi/spapr_vscsi: Prevent buffer overflow
7bde608 hw/scsi/spapr_vscsi: Do not mix SRP IU size with DMA buffer size
10ef238 hw/scsi/spapr_vscsi: Introduce req_iu() helper
06d1d9a hw/scsi/spapr_vscsi: Simplify a bit
89514b4 hw/scsi/spapr_vscsi: Use SRP_MAX_IU_LEN instead of sizeof flexible array
8cad997 hw/scsi/viosrp: Add missing 'hw/scsi/srp.h' include
684e72f spapr: Clean up RMA size calculation
4015194 spapr: Don't clamp RMA to 16GiB on new machine types
6ba055d spapr: Don't attempt to clamp RMA to VRMA constraint
37120d6 spapr,ppc: Simplify signature of kvmppc_rma_size()
ac722f8 spapr: Don't use weird units for MIN_RMA_SLOF
2c86473 target/ppc: Don't store VRMA SLBE persistently
2a4565f target/ppc: Only calculate RMLS derived RMA limit on demand
e6944cb target/ppc: Correct RMLS table
27bd1f5 target/ppc: Streamline calculation of RMA limit from LPCR[RMLS]
1d5b686 target/ppc: Use class fields to simplify LPCR masking
41f0aef target/ppc: Remove RMOR register from POWER9 & POWER10
f0bb56d spapr, ppc: Remove VPM0/RMLS hacks for POWER9
49d09fc target/ppc: Introduce ppc_hash64_use_vrma() helper
a604105 target/ppc: Correct handling of real mode accesses with vhyp on hash MMU
6fbdf8f ppc: Remove stub of PPC970 HID4 implementation
689d28f ppc: Remove stub support for 32-bit hypervisor mode
405c024 hw/ppc/pnv: Fix typo in comment
7532fbf spapr: Fix Coverity warning while validating nvdimm options
645463a ppc: Officially deprecate the CPU "compat" property
63c40f1 spapr: Handle pending hot plug/unplug requests at CAS
7d74e4f pseries: Update SLOF firmware image

=== OUTPUT BEGIN ===
1/45 Checking commit 7d74e4fe6d74 (pseries: Update SLOF firmware image)
2/45 Checking commit 63c40f1e53c0 (spapr: Handle pending hot plug/unplug 
requests at CAS)
3/45 Checking commit 645463ab9a98 (ppc: Officially deprecate the CPU "compat" 
property)
4/45 Checking commit 7532fbf9018e (spapr: Fix Coverity warning while validating 
nvdimm options)
5/45 Checking commit 405c024f407a (hw/ppc/pnv: Fix typo in comment)
6/45 Checking commit 689d28f975cf (ppc: Remove stub support for 32-bit 
hypervisor mode)
7/45 Checking commit 6fbdf8f49b17 (ppc: Remove stub of PPC970 HID4 
implementation)
8/45 Checking commit a604105404be (target/ppc: Correct handling of real mode 
accesses with vhyp on hash MMU)
9/45 Checking commit 49d09fc795a5 (target/ppc: Introduce ppc_hash64_use_vrma() 
helper)
10/45 Checking commit f0bb56d30022 (spapr, ppc: Remove VPM0/RMLS hacks for 
POWER9)
11/45 Checking commit 41f0aefbf75e (target/ppc: Remove RMOR register from 
POWER9 & POWER10)
12/45 Checking commit 1d5b6860959d (target/ppc: Use class fields to simplify 
LPCR masking)
13/45 Checking commit 27bd1f5741a5 (target/ppc: Streamline calculation of RMA 
limit from LPCR[RMLS])
14/45 Checking commit e6944cbf3ed9 (target/ppc: Correct RMLS table)
15/45 Checking commit 2a4565fd1852 (target/ppc: Only calculate RMLS derived RMA 
limit on demand)
16/45 Checking commit 2c864739b507 (target/ppc: Don't store VRMA SLBE 
persistently)
17/45 Checking commit ac722f832dad (spapr: Don't use weird units for 
MIN_RMA_SLOF)
18/45 Checking commit 37120d691e31 (spapr,ppc: Simplify signature of 
kvmppc_rma_size())
19/45 Checking commit 6ba055dea62c (spapr: Don't attempt to clamp RMA to VRMA 
constraint)
20/45 Checking commit 40151945633e (spapr: Don't clamp RMA to 16GiB on new 
machine types)
21/45 Checking commit 684e72f277f7 (spapr: Clean up RMA size calculation)
22/45 Checking commit 8cad997dd4dd (hw/scsi/viosrp: Add missing 'hw/scsi/srp.h' 
include)
23/45 Checking commit 89514b40c11f (hw/scsi/spapr_vscsi: Use SRP_MAX_IU_LEN 
instead of sizeof flexible array)
24/45 Checking commit 06d1d9a3c12f (hw/scsi/spapr_vscsi: Simplify a bit)
25/45 Checking commit 10ef2385fe33 (hw/scsi/spapr_vscsi: Introduce req_iu() 
helper)
26/45 Checking commit 7bde6080932a (hw/scsi/spapr_vscsi: Do not mix SRP IU size 
with DMA buffer size)
27/45 Checking commit e8ff332d14ad (hw/scsi/spapr_vscsi: Prevent buffer 
overflow)
28/45 Checking commit 397ec17b6ad5 (hw/scsi/spapr_vscsi: Convert debug 
fprintf() to trace event)
29/45 Checking commit 0e75479201cd (spapr/xive: use SPAPR_IRQ_IPI to define IPI 
ranges exposed to the guest)
30/45 Checking commit b824828a0f91 (target/ppc: Fix rlwinm on ppc64)
31/45 Checking commit f5bb44507880 (ppc/spapr: Move GPRs setup to one place)
32/45 Checking commit 446daceb3250 (pseries: Update SLOF firmware image)
33/45 Checking commit bf5265eafdbe (spapr/rtas: Reserve space for RTAS blob and 
log)
34/45 Checking commit 21a3ae278891 (spapr: Move creation of ibm, 
dynamic-reconfiguration-memory dt node)
WARNING: Block comments use a leading /* on a separate line
#310: FILE: hw/ppc/spapr.c:650:
+            /* spapr_machine_init() checks for rma_size <= node0_size

WARNING: Block comments use a trailing */ on a separate line
#311: FILE: hw/ppc/spapr.c:651:
+             * already */

WARNING: line over 80 characters
#403: FILE: hw/ppc/spapr.c:742:
+    _FDT((fdt_setprop_cell(fdt, offset, "slb-size", 
cpu->hash64_opts->slb_size)));

WARNING: line over 80 characters
#404: FILE: hw/ppc/spapr.c:743:
+    _FDT((fdt_setprop_cell(fdt, offset, "ibm,slb-size", 
cpu->hash64_opts->slb_size)));

WARNING: Block comments use a leading /* on a separate line
#420: FILE: hw/ppc/spapr.c:759:
+    /* Advertise VSX (vector extensions) if available

WARNING: Block comments use a trailing */ on a separate line
#425: FILE: hw/ppc/spapr.c:764:
+     * are possible, and all of those have VMX */

WARNING: Block comments use a leading /* on a separate line
#432: FILE: hw/ppc/spapr.c:771:
+    /* Advertise DFP (Decimal Floating Point) if available

WARNING: Block comments use a trailing */ on a separate line
#434: FILE: hw/ppc/spapr.c:773:
+     *   1               == DFP available */

total: 0 errors, 8 warnings, 534 lines checked

Patch 34/45 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
35/45 Checking commit 4e794060fae1 (spapr: Move creation of 
ibm,architecture-vec-5 property)
WARNING: line over 80 characters
#123: FILE: hw/ppc/spapr.c:1069:
+        _FDT(fdt_setprop_cell(fdt, chosen, "qemu,graphic-width", 
graphic_width));

WARNING: line over 80 characters
#124: FILE: hw/ppc/spapr.c:1070:
+        _FDT(fdt_setprop_cell(fdt, chosen, "qemu,graphic-height", 
graphic_height));

WARNING: line over 80 characters
#125: FILE: hw/ppc/spapr.c:1071:
+        _FDT(fdt_setprop_cell(fdt, chosen, "qemu,graphic-depth", 
graphic_depth));

WARNING: line over 80 characters
#142: FILE: hw/ppc/spapr.c:1085:
+            _FDT(fdt_setprop_string(fdt, chosen, "qemu,boot-device", 
boot_device));

WARNING: line over 80 characters
#153: FILE: hw/ppc/spapr.c:1096:
+            _FDT(fdt_setprop_string(fdt, chosen, "linux,stdout-path", 
stdout_path));

total: 0 errors, 5 warnings, 193 lines checked

Patch 35/45 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
36/45 Checking commit 6a32b195209c (spapr: Rename DT functions to newer naming 
convention)
37/45 Checking commit b4a37ddeedb7 (ppc/spapr: Fix FWNMI machine check failure 
handling)
38/45 Checking commit bed131fc204c (ppc/spapr: Change FWNMI names)
WARNING: Block comments use a leading /* on a separate line
#305: FILE: include/hw/ppc/spapr.h:197:
+    /* Machine Check Notification Routine address

WARNING: Block comments use a leading /* on a separate line
#312: FILE: include/hw/ppc/spapr.h:202:
+    /* Machine Check FWNMI synchronization, fwnmi_machine_check_interlock is

total: 0 errors, 2 warnings, 270 lines checked

Patch 38/45 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
39/45 Checking commit c9df752a19d8 (ppc/spapr: Add FWNMI System Reset state)
WARNING: Block comments use a leading /* on a separate line
#81: FILE: include/hw/ppc/spapr.h:197:
+    /* System Reset and Machine Check Notification Routine addresses

total: 0 errors, 1 warnings, 51 lines checked

Patch 39/45 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
40/45 Checking commit 91debae337f6 (ppc/spapr: Fix FWNMI machine check 
interrupt delivery)
41/45 Checking commit 3bd2159a5093 (ppc/spapr: Allow FWNMI on TCG)
42/45 Checking commit f1fef1fa71da (target/ppc: allow ppc_cpu_do_system_reset 
to take an alternate vector)
43/45 Checking commit 47df6f1786f7 (ppc/spapr: Implement FWNMI System Reset 
delivery)
WARNING: line over 80 characters
#50: FILE: hw/ppc/spapr.c:976:
+                         ms->smp.max_cpus * sizeof(uint64_t)*2 + 
sizeof(uint64_t)));

ERROR: code indent should never use tabs
#50: FILE: hw/ppc/spapr.c:976:
+^I^I^I  ms->smp.max_cpus * sizeof(uint64_t)*2 + sizeof(uint64_t)));$

ERROR: spaces required around that '*' (ctx:VxV)
#50: FILE: hw/ppc/spapr.c:976:
+                         ms->smp.max_cpus * sizeof(uint64_t)*2 + 
sizeof(uint64_t)));
                                                             ^

WARNING: line over 80 characters
#75: FILE: hw/ppc/spapr.c:3425:
+        addr = rtas_addr + RTAS_ERROR_LOG_MAX + cs->cpu_index * 
sizeof(uint64_t)*2;

ERROR: spaces required around that '*' (ctx:VxV)
#75: FILE: hw/ppc/spapr.c:3425:
+        addr = rtas_addr + RTAS_ERROR_LOG_MAX + cs->cpu_index * 
sizeof(uint64_t)*2;
                                                                                
 ^

total: 3 errors, 2 warnings, 59 lines checked

Patch 43/45 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

44/45 Checking commit 72735a9393da (ppc/spapr: Ignore common 
"ibm,nmi-interlock" Linux bug)
ERROR: code indent should never use tabs
#28: FILE: hw/ppc/spapr_rtas.c:465:
+^I * The vCPU that hit the NMI should invoke "ibm,nmi-interlock"$

ERROR: code indent should never use tabs
#30: FILE: hw/ppc/spapr_rtas.c:467:
+^I * for system reset interrupts, despite them not being interlocked.$

ERROR: code indent should never use tabs
#31: FILE: hw/ppc/spapr_rtas.c:468:
+^I * PowerVM silently ignores this and returns success here. Returning$

ERROR: code indent should never use tabs
#32: FILE: hw/ppc/spapr_rtas.c:469:
+^I * failure causes Linux to print the error "FWNMI: nmi-interlock$

ERROR: code indent should never use tabs
#33: FILE: hw/ppc/spapr_rtas.c:470:
+^I * failed: -3", although no other apparent ill effects, this is a$

ERROR: code indent should never use tabs
#34: FILE: hw/ppc/spapr_rtas.c:471:
+^I * regression for the user when enabling FWNMI. So for now, match$

ERROR: code indent should never use tabs
#35: FILE: hw/ppc/spapr_rtas.c:472:
+^I * PowerVM. When most Linux clients are fixed, this could be$

ERROR: code indent should never use tabs
#36: FILE: hw/ppc/spapr_rtas.c:473:
+^I * changed.$

ERROR: code indent should never use tabs
#37: FILE: hw/ppc/spapr_rtas.c:474:
+^I */$

total: 9 errors, 0 warnings, 20 lines checked

Patch 44/45 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

45/45 Checking commit 1689eda27bca (pseries: Update SLOF firmware image)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden